-
Notifications
You must be signed in to change notification settings - Fork 0
Fixed debug messages and removed trailing white space #1349
Fixed debug messages and removed trailing white space #1349
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve, based on visual inspection. I did not test, but this is so simple, I think if @akturner tested in MPAS-sea ice that is sufficient.
@akturner , this is clear to be merged. If you are comfortable doing so following the framework merge protocols, go ahead. If you're unsure, I can help you or do it. |
@matthewhoffman: I will merge next week when I return if thats acceptable on the schedule |
@akturner , yeah, that sounds fine. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the code changes look fine. I'm only requesting a merge message (i.e., the first comment on the PR) that describes the changes and that they are specifically for the forcing module.
@@ -1021,15 +1018,15 @@ subroutine get_initial_forcing_data(&!{{{ | |||
! cycle start time is inclusive to the cycle | |||
|
|||
if (forcingTimeCycle .lt. forcingGroup % forcingCycleStart) then | |||
do | |||
do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This carriage return here and on three following do's is very strange. Since you are cleaning up white space, could you change these to a single line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what you mean. The do is a separate statement and here means loop to infinity. The infinite loop is broken by an exit statement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aha! I had no idea - somehow that slipped through the cracks of 15 years of Fortran programming. I get it now. Please disregard my comment.
Tested by compiling |
There were several conflicts between this PR and #1417, mostly due to numerous white space corrections on both. I resolved the conflicts in the merge commit. |
Code cleanup and fixed messages in forcing module
Fixed debug messages with new logging system
Removed trailing whitespace