This repository has been archived by the owner on Oct 23, 2020. It is now read-only.
Removed block loop from time level shift in forcing #1417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested by compiling |
mark-petersen
approved these changes
Oct 3, 2017
mark-petersen
added a commit
that referenced
this pull request
Oct 3, 2017
The mpas_shift_time_levs routines do their own loop over blocks so it is a bug for the outer block loop in forcing_shift_data forcing routine. This bug prevents bfb results with multiple blocks on processors.
matthewhoffman
added a commit
that referenced
this pull request
Oct 10, 2017
Update needed for ACME Framework features brought in: * f444d0f Merge PR #1418 'matthewhoffman/framework/output_record_reference_time' into develop * 263e14f Merge PR #1428 'mark-petersen/framework/couple_fixes' into develop * bcce31d Merge PR #1424 'amametjanov:az/tools/cp-prebuilt-tools' into develop * 98cfeea Merge PR# 1349 'akturner/framework/forcing_cleanup' into develop * 9359319 Merge PR #1347 'akturner/framework/forcing_restart_timestamp' into develop * e9ce203 Merge PR #1348 'akturner/framework/forcing_at_init' into develop * 4974284 Merge PR #1368 'akturner/framework/improved_messages_in_driver' into develop * 86d50c5 Merge PR #1417 'akturner/framework/forcing_multiple_blocks' into develop * 9116da3 Merge branch 'framework/validation-of-streams-using-interval_in-interval_out' into develop * e466b46 Merge branch 'framework/interval_in-interval_out-support-for-streams' into develop * 30dc955 Merge branch 'az/framework/mpas_dmpar-race-fix' into develop * b632938 Merge branch 'framework/i8_interval_division' into develop * 6dac06c Merge branch 'framework/log_write_IBM_error' into develop * 960a648 Merge branch 'framework/cleanup-logging-stream-manager' into develop * 504c282 Merge branch 'framework/make-streams-with-direction-none-inactive' into develop * 5903748 Merge branch 'framework/correctly_remove_blk_fields' into develop * 3565965 Merge branch 'framework/iostreams-real4dfield-bug' into develop * 8b60591 Merge branch 'framework/missing-deallocate-nEdgesOnCellField-bootstrapping' into develop * 70b953b Merge branch 'master' into develop
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mpas_shift_time_levs routines do their own loop over blocks so it is a bug for the outer block loop in forcing_shift_data forcing routine. This bug prevents bfb results with multiple blocks on processors.