Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print max. temperature during dynamic adjustment #623

Merged
merged 1 commit into from
May 6, 2024

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Apr 29, 2023

We want to do this as a sanity check even if it is below the threshold that will raise an error.

Checklist

  • Document (in a comment titled Testing in this PR) any testing that was used to verify the changes

@xylar xylar self-assigned this Apr 29, 2023
@xylar xylar requested a review from dengwirda April 29, 2023 08:39
@xylar
Copy link
Collaborator Author

xylar commented Apr 29, 2023

This will require E3SM-Ocean-Discussion/E3SM#53

@xylar
Copy link
Collaborator Author

xylar commented Apr 29, 2023

Testing

I ran the EC30to60 suite through files_for_e3sm with E3SM-Ocean-Discussion/E3SM#53. With this improvement, we no longer see temperature exceeding the threshold of 33 degrees -- the max stays very close to 31.2.

/lcrc/group/e3sm/ac.xylar/compass_1.2/chrysalis/test_20230428/ec_with_redi_mono

@xylar
Copy link
Collaborator Author

xylar commented May 6, 2024

The E3SM changes were brought in in #744

@xylar
Copy link
Collaborator Author

xylar commented May 6, 2024

This was basically handled in #745. There is some printing here that has not made it in so merging for that purpose alone.

@xylar xylar force-pushed the use-redi-limting branch from a54f559 to 278f0b3 Compare May 6, 2024 18:28
@xylar xylar changed the title Switch to using Redi monotone limiter Print max. temperature during dynamic adjustment May 6, 2024
We want to do this as a sanity check even if it is below the threshold
that will raise an error.
@xylar xylar force-pushed the use-redi-limting branch from 278f0b3 to 79bf5d0 Compare May 6, 2024 18:53
@xylar
Copy link
Collaborator Author

xylar commented May 6, 2024

Reran the PR suite just to make sure nothing seems to be broken (comparing with a baseline from #810 and with this branch rebased onto that one). I also ran Icos240 through dynamic_adjustment to make sure it worked as expected and printed the max, and it did.

As desired, max of temperatureMax: 29.749005395578898 <= 33.0 in
  /lcrc/group/e3sm/ac.xylar/compass_1.3/chrysalis/test_20240506/icos240_for_e3sm_redi/ocean/global_ocean/Icos240/WOA23/dynamic_adjustment/damped_adjustment_1/analysis_members/globalStats.0001-01-01_00.00.00.nc
As desired, max of temperatureMax: 29.73397609428701 <= 33.0 in
  /lcrc/group/e3sm/ac.xylar/compass_1.3/chrysalis/test_20240506/icos240_for_e3sm_redi/ocean/global_ocean/Icos240/WOA23/dynamic_adjustment/simulation/analysis_members/globalStats.0001-01-02_00.00.00.nc
                                         

@xylar xylar merged commit 9b3e621 into MPAS-Dev:main May 6, 2024
4 checks passed
@xylar xylar deleted the use-redi-limting branch May 6, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant