Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update E3SM-Project submodule #744

Merged
merged 1 commit into from
Dec 3, 2023
Merged

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Dec 3, 2023

This merge updates the E3SM-Project submodule from 894b5b2 to 5d5f15c.

This update includes the following MPAS-Ocean and MPAS-Frameworks PRs (check mark indicates bit-for-bit with previous PR in the list):

Results of bit-for-bit testing with the pr test suite are in:

/lcrc/group/e3sm/ac.xylar/compass_1.2/chrysalis/test_20231202/update_e3sm_project

This merge updates the E3SM-Project submodule from [894b5b2](https://github.com/E3SM-Project/E3SM/tree/894b5b2) to [5d5f15c](https://github.com/E3SM-Project/E3SM/tree/5d5f15c).

This update includes the following MPAS-Ocean and MPAS-Frameworks PRs (check mark indicates bit-for-bit with previous PR in the list):
- [ ]  (ocn) E3SM-Project/E3SM#5945
- [ ]  (ocn) E3SM-Project/E3SM#5946
- [ ]  (ocn) E3SM-Project/E3SM#5947
- [ ]  (ocn) E3SM-Project/E3SM#5999
- [ ]  (ocn) E3SM-Project/E3SM#6037
- [ ]  (ocn) E3SM-Project/E3SM#5989
- [ ]  (ocn) E3SM-Project/E3SM#6035
- [ ]  (ocn) E3SM-Project/E3SM#6077
@xylar xylar self-assigned this Dec 3, 2023
@xylar
Copy link
Collaborator Author

xylar commented Dec 3, 2023

@mark-petersen and @hyungyukang, I'm seeing non-BFB changes in these 8 compass test cases for the AB2 PR. None of these test cases use AB2 so I'm wondering if you can help me explain this:

00:04 FAIL ocean_baroclinic_channel_10km_default
00:03 FAIL ocean_baroclinic_channel_10km_threads_test
00:03 FAIL ocean_baroclinic_channel_10km_decomp_test
00:03 FAIL ocean_baroclinic_channel_10km_restart_test
00:12 FAIL ocean_ice_shelf_2d_5km_z-star_restart_test
00:13 FAIL ocean_ice_shelf_2d_5km_z-level_restart_test
00:07 FAIL ocean_ziso_20km_default
00:06 FAIL ocean_ziso_20km_with_frazil

I used E3SM-Project/E3SM#6037 (the pervious ocean-related E3SM commit) as a baseline. I don't see any merges in between those 2 that could explain this but I also don't see anything to explain it in the AB2 PR.

Compass results are on Chrysalis at:

/lcrc/group/e3sm/ac.xylar/compass_1.2/chrysalis/test_20231202/update_e3sm_project/06_5989_6037

Update: I have run the same comparison but using E3SM-Project/E3SM#5555, the previous merge to E3SM-Project/E3SM#5989, as a baseline. I see the same 8 non-BFB results so E3SM-Project/E3SM#5989 is somehow responsible.

See:

/lcrc/group/e3sm/ac.xylar/compass_1.2/chrysalis/test_20231202/update_e3sm_project/5989_vs_5555

The differences are also quite a bit larger than machine precision:

temperature          Time index: 0, 1, 2
1:  l1: 6.58508052174920e-02  l2: 3.01293263945369e-03  linf: 3.83507589390319e-04
2:  l1: 8.31429726125332e-02  l2: 3.62895580345237e-03  linf: 4.27873571863913e-04
  FAIL /lcrc/group/e3sm/ac.xylar/compass_1.2/chrysalis/test_20231202/update_e3sm_project/5989_vs_5555/ocean/baroclinic_channel/10km/default/forward/output.nc
       /lcrc/group/e3sm/ac.xylar/compass_1.2/chrysalis/test_20231202/update_e3sm_project/5555_vs_6037/ocean/baroclinic_channel/10km/default/forward/output.nc
salinity             Time index: 0, 1, 2
1:  l1: 1.30526700559130e-11  l2: 3.04540307521063e-13  linf: 7.10542735760100e-15
2:  l1: 2.51958454100532e-11  l2: 4.38814073977611e-13  linf: 2.13162820728030e-14
  FAIL /lcrc/group/e3sm/ac.xylar/compass_1.2/chrysalis/test_20231202/update_e3sm_project/5989_vs_5555/ocean/baroclinic_channel/10km/default/forward/output.nc
       /lcrc/group/e3sm/ac.xylar/compass_1.2/chrysalis/test_20231202/update_e3sm_project/5555_vs_6037/ocean/baroclinic_channel/10km/default/forward/output.nc
layerThickness       Time index: 0, 1, 2
1:  l1: 1.68607094310147e-02  l2: 1.55323424416031e-04  linf: 4.29925921707763e-06
2:  l1: 2.42502588213114e-02  l2: 2.07838681915587e-04  linf: 4.01659313098435e-06
  FAIL /lcrc/group/e3sm/ac.xylar/compass_1.2/chrysalis/test_20231202/update_e3sm_project/5989_vs_5555/ocean/baroclinic_channel/10km/default/forward/output.nc
       /lcrc/group/e3sm/ac.xylar/compass_1.2/chrysalis/test_20231202/update_e3sm_project/5555_vs_6037/ocean/baroclinic_channel/10km/default/forward/output.nc
normalVelocity       Time index: 0, 1, 2
1:  l1: 1.17574589826693e-01  l2: 9.24265631508545e-04  linf: 3.76338900865969e-05
2:  l1: 1.68474540209029e-01  l2: 1.35016219080595e-03  linf: 5.79830916684343e-05
  FAIL /lcrc/group/e3sm/ac.xylar/compass_1.2/chrysalis/test_20231202/update_e3sm_project/5989_vs_5555/ocean/baroclinic_channel/10km/default/forward/output.nc
       /lcrc/group/e3sm/ac.xylar/compass_1.2/chrysalis/test_20231202/update_e3sm_project/5555_vs_6037/ocean/baroclinic_channel/10km/default/forward/output.nc
Baseline validation failed

@xylar
Copy link
Collaborator Author

xylar commented Dec 3, 2023

@mark-petersen and @hyungyukang, sorry, you can ignore the above comment. I now understand. The default config_time_integrator was changed to split_explicit_ab2 and these 8 tests presumably don't specify a value for config_time_integrator so they now use ab2.

@xylar xylar merged commit 36d0a0d into MPAS-Dev:main Dec 3, 2023
4 checks passed
@xylar xylar deleted the update_e3sm_project branch December 3, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant