-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add components to objects #825
Conversation
eb7c63d
to
06c8d2c
Compare
@n1k0 there is still some work to do, but I would to get some feedback first 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I'd expect component UUID to be implemented in the same patch but I'll leave this up to you if you want to land this first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more nits and remarks while I caught them
09790d3
to
a1b88c7
Compare
a1b88c7
to
2f476ef
Compare
ef03d3e
to
9c5c262
Compare
🔧 Problem
We want to be able to model the component notion. See the card for more details.
🍰 Solution
Add a level above the processes with a name and a quantity.
🚨 Points to watch/comments
Currently, components are built on the file from the example file. Their uniqueness is based on their name, it should be improved later on with component ids and a file listing the possible components.
It's not possible to modify processes on purpose, it should come later on.
Tests need to be added.
🏝️ How to test