Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(textile): update number of references index thresholds. #839

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

n1k0
Copy link
Member

@n1k0 n1k0 commented Nov 21, 2024

🔧 Problem

Notion card

Two problems:

  1. We want the thresholds applied to clearly distinguish:
    • Ultra fast fashion which should be at 0%
    • Fast fashion which should be around 50%
  2. We do not want the thresholds to:
    • Penalize brands that offer, for example, clothing for large sizes (this does not increase the choice offered to people who are not concerned)

🍰 Solution

Update thresholds; today the “largeur de gamme” index takes the following thresholds:

  • 100% when the number of references is less than 3000
  • 80% for 6,000 references
  • 50% for 10,000 references
  • 0% when the number of references is greater than 50,000

These should be replaced as following:

  • 100% when the number of references is less than 1,000
  • 80% for 6,000 references ⇒ this threshold is deleted
  • 50% for 7,000 references
  • 0% when the number of references is greater than 16,000

🏝️ How to test

Check that the computed non-physical durability index incorporates these changes adjusting the Nombre de références field value.

Note: unit tests have been updated, precise acceptance tests may eventually be added to the card as requested over mattermost.

@n1k0 n1k0 requested a review from vjousse November 21, 2024 09:20
Copy link
Collaborator

@vjousse vjousse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

src/Data/Textile/Economics.elm Show resolved Hide resolved
@n1k0 n1k0 merged commit ef6287d into master Nov 21, 2024
8 checks passed
@n1k0 n1k0 deleted the feat/update-nb-of-references-thresholds branch November 21, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants