Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce first version of object interface #756

Merged
merged 23 commits into from
Oct 1, 2024
Merged

Conversation

paulboosz
Copy link
Collaborator

@paulboosz paulboosz commented Sep 17, 2024

@n1k0
Copy link
Member

n1k0 commented Sep 26, 2024

@paulboosz our existing code for parsing impacts currently require to have the pef impact defined. Refactoring the whole textile/food impact parsing to exclude PEF is out of question in our timeline so we could either compute this PEF impact or set it to zero: your call. Note that this should also be reflected on ecobalyse-private for detailed impacts.

@n1k0 n1k0 force-pushed the object-v0 branch 2 times, most recently from 6208560 to a3a0768 Compare September 26, 2024 09:51
@n1k0 n1k0 requested a review from vjousse September 26, 2024 14:31
@n1k0 n1k0 marked this pull request as ready for review September 26, 2024 14:31
@n1k0
Copy link
Member

n1k0 commented Sep 26, 2024

@vjousse I think the PR is landable in this state as it doesn't affect public navigation, api, scores or anything at all. POs and curious enough users just have to know about the /#/object/simulator url and that's about it. You can decide to continue iterating on this branch, but I highly suggest landing this and creating other PRs next instead.

Copy link
Collaborator

@vjousse vjousse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First iteration ready to go for me as it is hidden by default.

@vjousse vjousse changed the title feat: first version of object interface feat: introduce first version of object interface Oct 1, 2024
@vjousse vjousse merged commit cff1761 into master Oct 1, 2024
8 checks passed
@vjousse vjousse deleted the object-v0 branch October 1, 2024 08:30
vjousse pushed a commit that referenced this pull request Oct 10, 2024
## [2.4.0](https://github.com/MTES-MCT/ecobalyse/compare/v2.3.0..v2.4.0)
(2024-10-10)



### πŸš€ Features

- Introduce first version of object interface
([#756](#756))

### πŸͺ² Bug Fixes

- Sync food ([#759](#759))
- Don't hide version information on staging
([#778](#778))
- Reset physical durablility in regulatory mode
([#786](#786))
- *(api,food)* Nullable fields weren't nullable anymore.
([#789](#789))

### 🚜 Refactor

- Small textile explorer improvements
([#773](#773))

### βš™οΈ Miscellaneous Tasks

- Don't download draft releases
([#771](#771))
- Remove `airTransportRatio` from examples
([#785](#785))
- Cleanup package-lock.json.
([#787](#787))
- Use builtin python action cache for pipenv
([#796](#796))
- Improve changelog by using `git-cliff`
([#768](#768))

<!-- generated by git-cliff -->

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants