Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reset physical durablility in regulatory mode #786

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

vjousse
Copy link
Collaborator

@vjousse vjousse commented Oct 7, 2024

πŸ”§ Problem

When switching from exploratory mode to regulatory mode, the physical durability is not reset.

Notion card

🍰 Solution

Add physicalDurability to the advanced query check.

🏝️ How to test

  • Go to the regulatory mode
  • Choose "Pull coton chine fast fashion"
  • Put the physical durability to 0.67
  • Switch to regulatory tab and check that this popup appears
    image
  • Confirm
  • On the regulatory tab, the durability coefficient should be back to 0.92
    image

@vjousse vjousse self-assigned this Oct 7, 2024
@vjousse vjousse requested a review from n1k0 October 7, 2024 08:59
Copy link
Member

@n1k0 n1k0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vjousse vjousse merged commit eae49d0 into master Oct 8, 2024
6 checks passed
@vjousse vjousse deleted the fix/reset-to-non-physical branch October 8, 2024 08:59
vjousse pushed a commit that referenced this pull request Oct 10, 2024
## [2.4.0](https://github.com/MTES-MCT/ecobalyse/compare/v2.3.0..v2.4.0)
(2024-10-10)



### πŸš€ Features

- Introduce first version of object interface
([#756](#756))

### πŸͺ² Bug Fixes

- Sync food ([#759](#759))
- Don't hide version information on staging
([#778](#778))
- Reset physical durablility in regulatory mode
([#786](#786))
- *(api,food)* Nullable fields weren't nullable anymore.
([#789](#789))

### 🚜 Refactor

- Small textile explorer improvements
([#773](#773))

### βš™οΈ Miscellaneous Tasks

- Don't download draft releases
([#771](#771))
- Remove `airTransportRatio` from examples
([#785](#785))
- Cleanup package-lock.json.
([#787](#787))
- Use builtin python action cache for pipenv
([#796](#796))
- Improve changelog by using `git-cliff`
([#768](#768))

<!-- generated by git-cliff -->

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants