-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improve object simulator. #799
Conversation
59b7cea
to
eb26239
Compare
960ac8e
to
6c901a0
Compare
b49b6ef
to
03ee786
Compare
03ee786
to
a6dcfd4
Compare
4f2ff8b
to
c307b8c
Compare
6bd5015
to
2c50378
Compare
@vjousse this is now ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nits but code wise it looks good to me. Just a little question: why can't we add more than 2 processes? We may allow having twice the same process?
@vjousse because we only have two processes available and having two distinct amounts of the same plastic would look weird I think… but that's probably some feedback we should get from POs. |
Shouldn't we display the density too to help understand the computation? |
I think it should be rendered in the explorer but here... I don't know, that would also clutter the ui. Let's wait for user feedback here. |
dd212b3
to
4b0ed3c
Compare
## [2.5.0](https://github.com/MTES-MCT/ecobalyse/compare/v2.4.0..v2.5.0) (2024-11-06) ### 🚀 Features - Add bookmarks for objects ([#781](#781)) - Add object explorer pages. ([#803](#803)) - Distinguish Objects from Veli. ([#813](#813)) - Display score without durability ([#815](#815)) - Textile export ([#808](#808)) - Object export ([#812](#812)) ### 🪲 Bug Fixes - Create object encrypted file for versions ([#800](#800)) - Improve object simulator. ([#799](#799)) - Fix encoded display name field. ([#820](#820)) ### 🚜 Refactor - Aggregate in python ([#794](#794)) - Turn food process category into a list ([#795](#795)) - Aggregate in python ([#807](#807)) ### ⚙️ Miscellaneous Tasks - Upgrade dependencies to their latest version, Oct. 2024. ([#801](#801)) - Add tolerance to tests comparison ([#810](#810)) - *(data)* New export ([#819](#819)) ###◀️ Revert - "refactor: aggregate in python" ([#806](#806)) <!-- generated by git-cliff --> Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
🔧 Problems
🍰 Solution
Implement or fix aforementioned tasks.
🏝️ How to test