feat: Textile export #808
Merged
feat: Textile export #808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alyse into agregate_in_python
…to agregate_in_python
n1k0
reviewed
Nov 4, 2024
| "primary": activity.get("primary"), | ||
| "geographicOrigin": activity["geographicOrigin"], | ||
| "defaultCountry": activity["defaultCountry"], | ||
| "priority": activity.get("priority"), |
There was a problem hiding this comment.
This field is never used by anything in the entire codebase it seems, and should be therefore removed entirely.
There was a problem hiding this comment.
Thx! You mean the priority field?
Btw I'll do another PR to do such changes
paulboosz
approved these changes
Nov 4, 2024
There was a problem hiding this comment.
Significant differences are for :
- cotton
- electric mixes
They've been investigated by @ccomb and confirmed to be desirable changes. It looks there was errors in the past values due to copy/pasting.
Overview of the differences (at most ~5% diff in total impact)
vjousse
pushed a commit
that referenced
this pull request
Nov 7, 2024
## [2.5.0](https://github.com/MTES-MCT/ecobalyse/compare/v2.4.0..v2.5.0) (2024-11-06) ### 🚀 Features - Add bookmarks for objects ([#781](#781)) - Add object explorer pages. ([#803](#803)) - Distinguish Objects from Veli. ([#813](#813)) - Display score without durability ([#815](#815)) - Textile export ([#808](#808)) - Object export ([#812](#812)) ### 🪲 Bug Fixes - Create object encrypted file for versions ([#800](#800)) - Improve object simulator. ([#799](#799)) - Fix encoded display name field. ([#820](#820)) ### 🚜 Refactor - Aggregate in python ([#794](#794)) - Turn food process category into a list ([#795](#795)) - Aggregate in python ([#807](#807)) ### ⚙️ Miscellaneous Tasks - Upgrade dependencies to their latest version, Oct. 2024. ([#801](#801)) - Add tolerance to tests comparison ([#810](#810)) - *(data)* New export ([#819](#819)) ###◀️ Revert - "refactor: aggregate in python" ([#806](#806)) <!-- generated by git-cliff --> Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Problem
The processes and materials for textile are a manual json file with copy-pasted impacts. This poses a risk of errors and a lack of traceability.
🍰 Solution
This PR implements an automated
textileexport similar to thefoodone, that start from aactivities.jsonfile that splits into the finalprocesses.json,processes_impacts.jsonandmaterial.jsonand retrieves the impacts from simapro after getting the process names from brightway through a simple search string.🚨 Points to watch/comments
This implies some refactoring to share code between
foodandtextile(and soonobject) and separate pure functions in thecommonmodule.We should also discuss about the resulting impacts changes.
🏝️ How to test
This should start from scratch by deleting the docker volumes, reimport all the databases into brightway, then do the export of food and textile.
At the end, after around 2h of hard work for the machine, you should get an empty
git diffand passing tests.Lasts ~210min on a 2017 notebook...
ecobalyse-private: textile_export