Add failing unit tests to reproduce issue #312 #313
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After afternoon of tracing through the code, I am giving up for the day :( I am observing that the protocol is pausing after sending the first round of buffer. _get_write_buffer_size at uvloop/uvloop/handles/stream.pyx Line 580 in 707fd4c returns 211072, which is my initial buffer minus 8192. __uv_stream_on_write_impl() is never called Then.. I got lost in https://github.com/libuv/libuv/blob/07ad32138f4d2285ba2226b5e20462b27b091a59/src/unix/stream.c#L1398 |
fantix
pushed a commit
to fantix/uvloop
that referenced
this pull request
May 9, 2020
fantix
pushed a commit
to fantix/uvloop
that referenced
this pull request
May 9, 2020
fantix
pushed a commit
to fantix/uvloop
that referenced
this pull request
May 13, 2020
fantix
pushed a commit
that referenced
this pull request
May 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reproduces #312
The problem looks to be reproduced on the darwin side of your CI, but not on linux.
https://travis-ci.org/MagicStack/uvloop/jobs/649663884?utm_medium=notification&utm_source=github_status