Skip to content

forcely add UV_HANDLE_READABLE on pipe_t #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 14, 2020
Merged

forcely add UV_HANDLE_READABLE on pipe_t #342

merged 2 commits into from
May 14, 2020

Conversation

fantix
Copy link
Member

@fantix fantix commented May 9, 2020 •
edited
Loading

@fantix fantix requested a review from 1st1 May 9, 2020 18:17
@fantix fantix force-pushed the t317-readable-wronly-pipe branch 2 times, most recently from 39cd41f to 90b9e7f Compare May 9, 2020 21:02
@fantix fantix marked this pull request as ready for review May 9, 2020 22:55
1st1
1st1 reviewed May 13, 2020
View reviewed changes
fantix and others added 2 commits May 13, 2020 15:33
@fantix fantix force-pushed the t317-readable-wronly-pipe branch from 90b9e7f to 88f9712 Compare May 13, 2020 20:33
@fantix fantix requested a review from 1st1 May 14, 2020 00:48
1st1
1st1 approved these changes May 14, 2020
View reviewed changes
Copy link
Member

@1st1 1st1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sigh. Hopefully they fix the API.

@1st1
Copy link
Member

1st1 commented May 14, 2020

Great job, Fantix.

@fantix fantix merged commit c392972 into MagicStack:master May 14, 2020
@fantix fantix deleted the t317-readable-wronly-pipe branch May 14, 2020 01:06
@tardyp
Copy link
Contributor

tardyp commented May 14, 2020

cool! appreciate you included my commit!

@fantix fantix mentioned this pull request Nov 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1st1 1st1 1st1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

create_subprocess_exec stdin writer does not write everything Assertion failure in uv__io_stop
3 participants
@fantix @1st1 @tardyp