Skip to content

Comments

fix: center "Go Back" button on 404 page for mobile view#1334

Merged
MrgSub merged 4 commits intoMail-0:stagingfrom
kartik-212004:fix/404-mobile-alignment
Jun 17, 2025
Merged

fix: center "Go Back" button on 404 page for mobile view#1334
MrgSub merged 4 commits intoMail-0:stagingfrom
kartik-212004:fix/404-mobile-alignment

Conversation

@kartik-212004
Copy link
Contributor

@kartik-212004 kartik-212004 commented Jun 17, 2025

Fix: Center "Go Back" button on 404 page (mobile view)

Description

This PR fixes the alignment issue of the "Go Back" button on the 404-error page for mobile devices. Previously, the button was misaligned, leading to a poor user experience on smaller screens.

Type of Change

Please delete options that are not relevant.

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • 🎨 UI/UX improvement

Areas Affected

  • User Interface/Experience

Testing Done

  • Cross-browser testing (if UI changes)
  • Mobile responsiveness verified (if UI changes)

Security Considerations

For changes involving data or authentication:

  • No sensitive data is exposed
  • Authentication checks are in place
  • Input validation is implemented
  • Rate limiting is considered (if applicable)

Checklist

  • I have read the CONTRIBUTING document
  • My code follows the project's style guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in complex areas
  • I have updated the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix/feature works
  • All tests pass locally
  • Any dependent changes are merged and published

Screenshots/Recordings

before :

404.mp4

after:

404-solved.mp4

By submitting this pull request, I confirm that my contribution is made under the terms of the project's license.

Summary by CodeRabbit

  • Style
    • Centered buttons horizontally in the "Not Found" page for improved visual alignment.
    • Enhanced the layout of the mobile navigation menu for better structure and consistency.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jun 17, 2025

Walkthrough

The changes update CSS classes in two components to improve layout and alignment. In the NotFound component, button alignment is now centered. In the mobile navigation menu, a container is explicitly set as a flex column, and minor whitespace is removed from image attributes. No logic or exported entities were altered.

Changes

Files Change Summary
apps/mail/app/root.tsx Added justify-center to button container for horizontal centering.
apps/mail/components/navigation.tsx Added flex flex-col to a div and removed whitespace from img attrs.

Suggested reviewers

  • MrgSub

Poem

In the code where layouts dwell,
A flex grows strong, aligned so well.
Buttons now centered, neat and tight,
Navigation columns set just right.
With every tweak, our styles bloom—
A rabbit hops through CSS room! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bbd9c71 and 6b2d8f0.

📒 Files selected for processing (2)
  • apps/mail/app/root.tsx (1 hunks)
  • apps/mail/components/navigation.tsx (1 hunks)
🔇 Additional comments (3)
apps/mail/app/root.tsx (1)

165-165: Center 'Go Back' button on mobile 404 page.

Adding justify-center properly centers the button within its flex container on mobile screens. No issues detected.

apps/mail/components/navigation.tsx (2)

226-226: Clean up trailing whitespace in image attributes.

Removed the extra space after dark:hidden, keeping the class list tidy and avoiding unintended style overrides.


234-234: Ensure vertical stacking for mobile nav links.

Adding flex flex-col alongside space-y-3 explicitly defines a column layout with consistent spacing for the navigation links.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@MrgSub MrgSub merged commit d02505d into Mail-0:staging Jun 17, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants