Fix/duplicate privacy option in navigation menu in mobile view and inconsistent vertical spacing in the navigation links#2004
Conversation
WalkthroughMobile navigation sheet styling adjusted: removed mt-2 from Home and Pricing links, and removed the standalone Privacy item. No changes to handlers, routes, or exported interfaces. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (4)
apps/mail/components/navigation.tsx (4)
252-256: Use SPA navigation for internal About links and close the sheet on tap.Right now these are hard navigations, which reload the app. Use Link for snappier UX and explicitly close the sheet, like you did for Home/Pricing.
- {aboutLinks.map((link) => ( - <a key={link.title} href={link.href} className="block font-medium"> - {link.title} - </a> - ))} + {aboutLinks.map((link) => ( + <Link + key={link.title} + to={link.href} + onClick={() => setOpen(false)} + className="block font-medium" + > + {link.title} + </Link> + ))}
269-279: Don’t use react-router Link for external URLs; add a11y for icon-only links.External destinations should be plain anchors. Also, icon-only links need an accessible name (aria-label or sr-only text). Let’s match the desktop pattern and avoid accidental client-side routing assumptions.
- <Link - key={resource.title} - to={resource.href} - className="flex items-center gap-2 font-medium" - > - {resource.platform && <Icon className="dark:fill-muted-foreground h-5 w-5" />} - </Link> + <a + key={resource.title} + href={resource.href} + target="_blank" + rel="noopener noreferrer" + aria-label={resource.title} + className="flex items-center gap-2 font-medium" + > + {resource.platform && ( + <Icon className="dark:fill-muted-foreground h-5 w-5" aria-hidden="true" /> + )} + </a>
162-168: Desktop nav still duplicates “Privacy” (top-level + Company > Privacy). Intentional?Mobile duplication is fixed — good. But desktop keeps two entry points to the same page. If that’s not a deliberate product choice, remove the standalone Privacy button to keep IA clean.
- <NavigationMenuItem className="bg-transparent text-white cursor-pointer"> - <a href="/privacy"> - <Button variant="ghost" className="ml-1 h-9 bg-transparent"> - Privacy - </Button> - </a> - </NavigationMenuItem>Also applies to: 129-136
219-221: Add an accessible name to the menu icon button.Tiny change, big usability for screen readers. Humans plus robots = better together.
- <Button variant="ghost" size="icon" className="fixed left-4 top-6 z-50"> + <Button variant="ghost" size="icon" aria-label="Open menu" className="fixed left-4 top-6 z-50"> <Menu className="h-6 w-6" /> </Button>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
apps/mail/components/navigation.tsx(1 hunks)
🧰 Additional context used
📓 Path-based instructions (4)
**/*.{css,js,ts,jsx,tsx,mdx}
📄 CodeRabbit inference engine (.cursor/rules/tailwind-css-v4.mdc)
**/*.{css,js,ts,jsx,tsx,mdx}: Chain variants together for composable variants (e.g.,group-has-data-potato:opacity-100).
Use new variants such asstarting,not-*,inert,nth-*,in-*,open(for:popover-open), and**for all descendants.
Do not use deprecated utilities likebg-opacity-*,text-opacity-*,border-opacity-*, anddivide-opacity-*; use the new syntax (e.g.,bg-black/50).
Use renamed utilities:shadow-smis nowshadow-xs,shadowis nowshadow-sm,drop-shadow-smis nowdrop-shadow-xs,drop-shadowis nowdrop-shadow-sm,blur-smis nowblur-xs,bluris nowblur-sm,rounded-smis nowrounded-xs,roundedis nowrounded-sm,outline-noneis nowoutline-hidden.
Usebg-(--brand-color)syntax for CSS variables in arbitrary values instead ofbg-[--brand-color].
Stacked variants now apply left-to-right instead of right-to-left.
Files:
apps/mail/components/navigation.tsx
**/*.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (AGENT.md)
**/*.{js,jsx,ts,tsx}: Use 2-space indentation
Use single quotes
Limit lines to 100 characters
Semicolons are required
Files:
apps/mail/components/navigation.tsx
**/*.{js,jsx,ts,tsx,css}
📄 CodeRabbit inference engine (AGENT.md)
Use Prettier with sort-imports and Tailwind plugins
Files:
apps/mail/components/navigation.tsx
**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENT.md)
Enable TypeScript strict mode
Files:
apps/mail/components/navigation.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: cubic · AI code reviewer
2 participants
Description
This PR fixes the inconsistent vertical spacing in the navigation links in the mobile view by removing the extra margin (mt-2) and relying only on space-y-3. Also, there was one duplicate Privacy option which was removed.
Type of Change
Areas Affected
UI/UX
Please check all that apply:
Testing Done
Describe the tests you've done:
Checklist
Screenshots/Recordings
Current behaviour
Expected behaviour
By submitting this pull request, I confirm that my contribution is made under the terms of the project's license.
Summary by cubic
Fixes mobile navigation by removing a duplicate Privacy link and normalizing vertical spacing between links. Dropped per-link mt-2 in favor of space-y-3 for consistent spacing.
Summary by CodeRabbit