Skip to content

Comments

style: landing#1239

Merged
MrgSub merged 3 commits intoMail-0:stagingfrom
vachmara:style-landing
Jun 7, 2025
Merged

style: landing#1239
MrgSub merged 3 commits intoMail-0:stagingfrom
vachmara:style-landing

Conversation

@vachmara
Copy link
Contributor

@vachmara vachmara commented Jun 7, 2025

Description

Quick UI/UX fix for the landing page:

  • The back button and theme toggle were not accessible on desktop due to the navigation bar positionning:
    image
  • On mobile, the back button UX has been improved on the Terms and Privacy pages.

Type of Change

Please delete options that are not relevant.

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature with breaking changes)
  • 📝 Documentation update
  • 🎨 UI/UX improvement
  • 🔒 Security enhancement
  • ⚡ Performance improvement

Areas Affected

Please check all that apply:

  • Email Integration (Gmail, IMAP, etc.)
  • User Interface/Experience
  • Authentication/Authorization
  • Data Storage/Management
  • API Endpoints
  • Documentation
  • Testing Infrastructure
  • Development Workflow
  • Deployment/Infrastructure

Testing Done

Describe the tests you've done:

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed
  • Cross-browser testing (if UI changes)
  • Mobile responsiveness verified (if UI changes)

Checklist

  • I have read the CONTRIBUTING document
  • My code follows the project's style guidelines
  • I have performed a self-review of my code

By submitting this pull request, I confirm that my contribution is made under the terms of the project's license.

Summary by CodeRabbit

  • Style
    • Adjusted the position of the "Back" button on the Privacy Policy and Terms pages, moving it to the top-right corner on small screens for better accessibility.
    • Updated the desktop navigation header to be centered with a fixed maximum width, improving the visual layout on larger screens.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jun 7, 2025

Walkthrough

The changes adjust the positioning and layout of navigation and "Back" buttons in the privacy and terms pages, and update the desktop navigation header styling. Button containers are moved from the top-left to the top-right on small screens, while the navigation header is centered with a maximum width on desktop.

Changes

File(s) Change Summary
apps/mail/app/(full-width)/privacy.tsx,
apps/mail/app/(full-width)/terms.tsx
Updated the "Back" button container's absolute positioning: moved from top-left to top-right on small screens; medium screen positioning remains mostly unchanged.
apps/mail/components/navigation.tsx Modified desktop navigation header's styling to center it with a max width, replacing previous full-width layout.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant PrivacyPage
    participant TermsPage
    participant NavigationHeader

    User->>PrivacyPage: Loads Privacy Policy
    PrivacyPage->>User: Displays Back button (top-right on small screens)

    User->>TermsPage: Loads Terms of Service
    TermsPage->>User: Displays Back button (top-right on small screens)

    User->>NavigationHeader: Navigates on desktop
    NavigationHeader->>User: Shows centered header with max width
Loading

Suggested reviewers

  • ahmetskilinc

Poem

A button hops from left to right,
In corners new, it finds its light.
The header stands, both proud and wide,
Now centered, with some max inside.
With every tweak, the pages gleam—
A rabbit’s joy in CSS dream!
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8d97bf9 and 97891b7.

📒 Files selected for processing (2)
  • apps/mail/app/(full-width)/privacy.tsx (1 hunks)
  • apps/mail/app/(full-width)/terms.tsx (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • apps/mail/app/(full-width)/privacy.tsx
  • apps/mail/app/(full-width)/terms.tsx
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

♻️ Duplicate comments (1)
apps/mail/app/(full-width)/privacy.tsx (1)

27-27: Duplicate: Clear right offset at medium breakpoint
This change needs the same fix as in terms.tsx: add md:right-auto to override the global right-4 at md+.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 01867f0 and 8d97bf9.

📒 Files selected for processing (3)
  • apps/mail/app/(full-width)/privacy.tsx (1 hunks)
  • apps/mail/app/(full-width)/terms.tsx (1 hunks)
  • apps/mail/components/navigation.tsx (1 hunks)
🔇 Additional comments (1)
apps/mail/components/navigation.tsx (1)

85-85: Desktop navigation header centering looks correct
Centering the fixed header using left-[50%] + translate-x-[-50%] alongside max-w-3xl and w-full ensures a responsive, centered layout on desktop without layout shifts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants