Skip to content

fix: back button position on about page (mobile)#1433

Merged
MrgSub merged 1 commit intoMail-0:stagingfrom
asrvd:fix/back-btn-position-about-page
Jun 23, 2025
Merged

fix: back button position on about page (mobile)#1433
MrgSub merged 1 commit intoMail-0:stagingfrom
asrvd:fix/back-btn-position-about-page

Conversation

@asrvd
Copy link
Contributor

@asrvd asrvd commented Jun 22, 2025

Description

The back button position on about page on mobile screens was wrong and was overlapping with menu button.


Type of Change

Please delete options that are not relevant.

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature with breaking changes)
  • 📝 Documentation update
  • 🎨 UI/UX improvement
  • 🔒 Security enhancement
  • ⚡ Performance improvement

Areas Affected

Please check all that apply:

  • Email Integration (Gmail, IMAP, etc.)
  • User Interface/Experience
  • Authentication/Authorization
  • Data Storage/Management
  • API Endpoints
  • Documentation
  • Testing Infrastructure
  • Development Workflow
  • Deployment/Infrastructure

Testing Done

Describe the tests you've done:

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed
  • Cross-browser testing (if UI changes)
  • Mobile responsiveness verified (if UI changes)

Security Considerations

For changes involving data or authentication:

  • No sensitive data is exposed
  • Authentication checks are in place
  • Input validation is implemented
  • Rate limiting is considered (if applicable)

Checklist

  • I have read the CONTRIBUTING document
  • My code follows the project's style guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in complex areas
  • I have updated the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix/feature works
  • All tests pass locally
  • Any dependent changes are merged and published

Additional Notes

Add any other context about the pull request here.

Screenshots/Recordings

before -
image

after-
image


By submitting this pull request, I confirm that my contribution is made under the terms of the project's license.

Summary by CodeRabbit

  • Style
    • Updated the position of the "Back" button on the About page, moving it to the top-right corner on small screens while keeping it left-aligned on medium and larger screens for improved visual consistency.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jun 22, 2025

Walkthrough

The change updates the positioning of the "Back" button container on the About page, moving it from the top-left to the top-right corner on small screens, while keeping it left-aligned on medium and larger screens. No other content or logic has been modified.

Changes

File(s) Change Summary
apps/mail/app/(full-width)/about.tsx Adjusted CSS classes to move the "Back" button from top-left to top-right on small screens; no logic changes.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant AboutPage
    User->>AboutPage: Visit About page
    AboutPage-->>User: Render page with "Back" button (top-right on small screens, top-left on medium+)
Loading

Possibly related issues

Possibly related PRs

  • style: landing #1239: Both PRs adjust the "Back" button's position in full-width page components, shifting alignment on small screens.

Suggested reviewers

  • MrgSub

Poem

A button once left, now hops to the right,
On small screens it moves, a swift little flight.
On larger displays, it stays left in delight—
A rabbit’s small tweak, to make layouts just right!
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 89b47ec and 6f8e767.

📒 Files selected for processing (1)
  • apps/mail/app/(full-width)/about.tsx (1 hunks)
🔇 Additional comments (1)
apps/mail/app/(full-width)/about.tsx (1)

13-13: Correct responsive back button placement
The updated className shifts the button to right-4 top-6 on small screens and properly resets positioning with md:left-8 md:right-auto md:top-8 on medium+ screens. This resolves the overlap on mobile while preserving the original layout on larger viewports.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@MrgSub MrgSub merged commit c95a15c into Mail-0:staging Jun 23, 2025
3 checks passed
krakenftw pushed a commit to krakenftw/Zero that referenced this pull request Jun 24, 2025
@asrvd asrvd deleted the fix/back-btn-position-about-page branch July 6, 2025 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants