Remove brain state dependency and fix Gmail subscription key format

[MrgSub]

Fix AI Summary Display and Gmail Subscription Key Format

Description

This PR includes three key changes:

1. Removed the conditional rendering of the AiSummary component based on brainState.enabled, allowing the component to handle its own visibility logic.
2. Fixed the Gmail subscription key format in the server by using a composite key format ${id}__${providerId} instead of just id when accessing the gmail_sub_age KV store.
3. Temporarily commented out thread synchronization logic in the agent routes due to issues with Durable Object storage resetting.

Type of Change

• 🐛 Bug fix (non-breaking change which fixes an issue)

Areas Affected

• Email Integration (Gmail, IMAP, etc.)
• User Interface/Experience
• Data Storage/Management

Testing Done

• Manual testing performed

Checklist

• I have performed a self-review of my code
• My changes generate no new warnings

Additional Notes

The commented-out thread synchronization code includes a TODO note explaining that the Durable Object storage is sometimes resetting. This is a temporary measure until we can properly address the underlying issue.

---

By submitting this pull request, I confirm that my contribution is made under the terms of the project's license.

Summary by CodeRabbit

• Bug Fixes

  • AI summary is now always displayed in the mail display, regardless of previous conditions.
  • Improved accuracy in tracking Google subscription expiration by distinguishing between different account-provider pairs.

• Chores

  • Temporarily disabled folder sync trigger in thread retrieval due to intermittent storage resets; sync logic will be revisited in the future.

[jazzberry-ai]

Bug Report

Name	Severity	Example test case	Description
Gmail Subscription Key Migration Missing	High	1. User has an existing Gmail connection with active subscriptions. 2. Deploy the updated code with the new subscription key format. 3. Observe that the Gmail integration stops syncing emails. 4. Check the gmail_sub_age Durable Object to confirm that the old subscription key is no longer being updated.	The update to the Gmail subscription key format in apps/server/src/main.ts from id to ${id}\_\_{providerId} lacks a migration strategy. This will cause existing Gmail subscriptions to break, requiring users to reconnect their accounts.
AI Summary Always Rendered	Medium	1. User disables the AI summary feature in settings. 2. User opens an email. 3. Observe that the AI summary component is still rendered.	The removal of the brainState?.enabled check in apps/mail/components/mail/mail-display.tsx causes the AI summary component to always render, ignoring the user's settings.
Potential Data Inconsistency	Medium	1. Experience a "DO storage reset" (as described in the code comments). 2. Observe that some email folders are not fully synced, with missing or outdated emails.	The commenting out of thread syncing logic in apps/server/src/routes/agent/index.ts due to potential Durable Object storage issues may lead to data inconsistency, where email folders are not fully synced.

_{Comments? Email us. This is the last day of your free trial. Subscribe at jazzberry.ai.}

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

This update removes conditional logic for rendering the <AiSummary /> component in the mail UI, making its display unconditional. On the backend, it changes the key format for storing Gmail subscription timestamps to include both account and provider IDs. Additionally, it comments out folder sync trigger logic in mail thread retrieval due to storage reset concerns.

Changes

Cohort / File(s)	Change Summary
Mail Display Component apps/mail/components/mail/mail-display.tsx	Removed useBrainState import and usage; <AiSummary /> is now always rendered, unconditionally.
Gmail Subscription Key Handling apps/server/src/main.ts	Changed KV storage key for Gmail subscription age to use both account and provider IDs.
Mail Sync Logic (ZeroDriver) apps/server/src/routes/agent/index.ts	Commented out folder thread count checks and conditional sync trigger in getThreadsFromDB.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant MailDisplay
    participant AiSummary

    User->>MailDisplay: Render mail display
    MailDisplay->>AiSummary: Render (always, no condition)

Loading

sequenceDiagram
    participant Scheduler
    participant KVStore
    participant SubscriptionChecker

    Scheduler->>SubscriptionChecker: Check expired subscriptions
    SubscriptionChecker->>KVStore: Get timestamp using id__providerId key
    KVStore-->>SubscriptionChecker: Return timestamp
    SubscriptionChecker->>Scheduler: Continue processing

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Possibly related PRs

• perf(server): parallelize and batch mail sync #1788: Both PRs modify mail sync logic in apps/server/src/routes/agent/index.ts, with this PR disabling folder sync checks and the related PR refactoring sync methods.
• Optimize thread synchronization with rate limiting and concurrency control #1845: Both PRs update synchronization logic in the same module, with this PR commenting out sync triggers and the related PR adding rate limiting and concurrency control.
• Typo #1608: Both PRs involve disabling or altering getThreadsFromDB functionality, though in different classes and contexts.

Suggested labels

high priority

Poem

🚀
Code flows like rockets, logic realigned,
Sync triggers paused, new keys combined.
AiSummary shines with no more delay,
Backend and frontend, both pave the way.
Through commented lines and keys that entwine,
Progress marches onward—by design!

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2e46251 and f327830.

📒 Files selected for processing (3)

• apps/mail/components/mail/mail-display.tsx (1 hunks)
• apps/server/src/main.ts (1 hunks)
• apps/server/src/routes/agent/index.ts (1 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch ZERORemove_brain_state_dependency_and_fix_Gmail_subscription_key_format

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[greptile-apps]

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

[MrgSub]

• Remove brain state dependency and fix Gmail subscription key format #1848 👈 (View in Graphite)
• staging

This stack of pull requests is managed by Graphite. Learn more about stacking.

[MrgSub]

Merge activity

• Jul 28, 4:57 AM UTC: A user started a stack merge that includes this pull request via Graphite.
• Jul 28, 4:57 AM UTC: @MrgSub merged this pull request with Graphite.