Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Caution Review failedThe pull request is closed. WalkthroughThis pull request updates the localization JSON files for the mail application across multiple languages. The changes standardize several key strings by updating the capitalization of actions such as “Move to Spam” and “Mark as Unread” and adding a new “Mark as Read” entry. New mail actions (e.g., Reply, Reply All, Forward, Labels, Create New Label, No labels available) and settings messages (Settings not found, Settings saved, Failed to save settings, Language changed to {locale}) have been introduced. Additionally, some files now include entries for language and timezone selection, and a new Czech localization file has been added. Changes
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (10)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (8)
apps/mail/locales/cs.json (1)
1-337: [Localization Consistency]:
The Czech localization file is well-structured and includes a comprehensive set of UI strings. However, several entries still remain in English (e.g.,"moveToSpam": "Move to Spam","markAsUnread": "Mark as Unread","markAsRead": "Mark as Read", and"favourites": "Favourites"). Please verify whether these should be translated into Czech or intentionally left as-is.apps/mail/locales/ko.json (1)
1-337: [Localization Review]:
The Korean localization file is generally well-translated. However, a few entries (such as"moveToSpam","markAsUnread", and"markAsRead") are still in English. Please double-check if translated equivalents should be provided to maintain consistency across the UI.apps/mail/locales/tr.json (1)
1-337: [Translation Accuracy]:
The Turkish localization file mostly reflects accurate translations. However, several key entries remain in English within the"threadDisplay"(e.g.,"moveToSpam","markAsUnread","markAsRead","favourites") and"settings"sections (e.g.,"notFound","saved","failedToSave","languageChanged"). Please verify these with the Crowdin updates and update them to Turkish if necessary.apps/mail/locales/ja.json (2)
119-127: Standardization of Thread Display Actions
The entries in the "threadDisplay" section (e.g."moveToSpam","markAsUnread","markAsRead","muteThread", and"favourites") have been updated to use explicit English phrases. Please verify that this change aligns with the overall localization strategy, especially since other parts of the UI may still use localized (Japanese) text.
218-223: New Mail Action Entries Added
New entries under the "mail" section—such as"reply","replyAll","forward","labels","createNewLabel", and"noLabelsAvailable"—have been introduced in English. Confirm that using English for these particular actions is intentional and consistent with the standardization effort across locales.apps/mail/locales/pt.json (1)
119-127: Standardization of Thread Display Actions
The thread display keys (including"moveToSpam","markAsUnread","markAsRead","muteThread", and"favourites") are now set to English phrases. Please double-check that this shift—while other parts of the UI may remain translated—meets the intended user experience for Portuguese users.apps/mail/locales/lv.json (1)
212-223: New Mail Action Entries in the Mail Section
New mail action keys (like"reply","replyAll","forward","labels","createNewLabel", and"noLabelsAvailable") have been integrated using English text. Verify that this mix of English with Latvian (or any localized strings) is intentional and consistent with similar changes in other locales.apps/mail/locales/fr.json (1)
119-127: Standardization of Thread Display Actions in French Localization
In the "threadDisplay" section, keys like"moveToSpam","markAsUnread", and"markAsRead"now use standardized English strings. Although the rest of the UI remains in French, please confirm that this deliberate mix meets the project’s localization goals and that users will understand the action labels.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (14)
apps/mail/locales/ar.json(4 hunks)apps/mail/locales/ca.json(4 hunks)apps/mail/locales/cs.json(1 hunks)apps/mail/locales/de.json(4 hunks)apps/mail/locales/es.json(5 hunks)apps/mail/locales/fr.json(4 hunks)apps/mail/locales/hi.json(4 hunks)apps/mail/locales/ja.json(4 hunks)apps/mail/locales/ko.json(4 hunks)apps/mail/locales/lv.json(5 hunks)apps/mail/locales/pl.json(4 hunks)apps/mail/locales/pt.json(4 hunks)apps/mail/locales/ru.json(5 hunks)apps/mail/locales/tr.json(3 hunks)
🔇 Additional comments (26)
apps/mail/locales/pl.json (1)
1-337:Details
❓ Verification inconclusive
[Translation Verification]:
Although this file is intended for Polish localization, nearly all of the strings remain in English. Please confirm if the Polish translations are pending or if an update from Crowdin is required to replace these entries with proper Polish text.
Translation Verification – Polish Localization Update
It appears that the
apps/mail/locales/pl.jsonfile, which is intended for Polish localization, contains English strings throughout. Please confirm whether the Polish translations are still pending (for example, from a Crowdin update) or if these English entries are intended as temporary fallback values.
- Verify if the translations need to be updated from Crowdin.
- Confirm whether the current English texts should be replaced once the Polish strings are available.
apps/mail/locales/ar.json (1)
1-337:Details
❓ Verification inconclusive
[Localization Consistency]:
The Arabic localization file appears to retain English strings throughout, including both pre-existing and new entries (e.g.,"Mark as Read"and various settings messages). Confirm that this is the intended outcome; otherwise, ensure that proper Arabic translations are applied based on the latest Crowdin updates.
Localization Check – Verification Needed:
The Arabic localization file (apps/mail/locales/ar.json) currently contains English strings for many entries (e.g.,"Mark as Read", settings messages, etc.). Please confirm that this fallback behavior is intentional. If not, update the file with the proper Arabic translations based on the latest Crowdin updates.
- Verify if the current English strings are meant to serve as fallbacks where translations are missing.
- If updated translations exist on Crowdin, please propagate those changes to this file accordingly.
apps/mail/locales/ca.json (3)
119-127: Thread Display Keys Updated
The strings in the"threadDisplay"block—specifically for"moveToSpam","markAsUnread","markAsRead", and"favourites"—have been replaced with English values. Please confirm that using English in the Catalan locale is intentional and aligns with the overall design update.
188-193: New Settings Section Added
A new"settings"section has been introduced with keys"notFound","saved","failedToSave", and"languageChanged". These entries use English text. Verify that this is the desired behavior for the Catalan localization or if further translation is needed at a later stage.
260-262: General Settings Labels in English
The labels"selectLanguage"and"selectTimezone"in the"pages" → "settings" → "general"section have been updated to English. Please ensure this change is consistent with your update objectives across all locales.apps/mail/locales/es.json (4)
119-127: Thread Display Translations Updated
Within the"threadDisplay"block, the action keys now display English phrases (e.g."Move to Spam","Mark as Unread", and"Mark as Read") along with updated values for"muteThread"and"favourites". Please verify that these changes are acceptable for the Spanish localization update.
188-193: New Settings Section in Spanish
A new"settings"section has been added containing"notFound","saved","failedToSave", and"languageChanged". These entries remain in English. Confirm that this is the preferred approach for the Spanish locale at this stage.
212-223: New Mail Action Entries Added
New keys have been added to the"mail"block—including"markAsRead","reply","replyAll","forward","labels","createNewLabel", and"noLabelsAvailable"—all with English text. Please double-check that this update meets your project’s standardization goals and that no Spanish-specific translations are required.
259-263: General Settings Labels Updated
The general settings section now uses the English labels"Select a language"and"Select a timezone". Please confirm that this change is consistent with the overall locale update.apps/mail/locales/ru.json (2)
115-123: Thread Display Translations Updated
In the"threadDisplay"section, keys such as"moveToSpam","markAsUnread", and"markAsRead"now have English values. Please verify that these updates are in line with your intended localization for the Russian interface.
188-193: New Settings Section Added
A new"settings"block with entries"notFound","saved","failedToSave", and"languageChanged"is now present and uses English text. Confirm that you intend for these keys to remain untranslated in the Russian locale at this update stage.apps/mail/locales/hi.json (4)
115-127: Thread Display Translations Updated
The"threadDisplay"section now uses English texts for keys"moveToSpam","markAsUnread", and"markAsRead", with"muteThread"and"favourites"following suit. Please ensure that these changes are acceptable for the Hindi locale given your update goals.
188-193: New Settings Section in Hindi
A new"settings"section has been added with the keys"notFound","saved","failedToSave", and"languageChanged", all in English. Verify that this approach meets your localization goals for Hindi at this time.
212-223: New Mail Action Entries Added
The"mail"block now features several new keys—namely"markAsRead","reply","replyAll","forward","labels","createNewLabel", and"noLabelsAvailable"—presented in English. Please check that using English in these entries aligns with your overall strategy for the Hindi version.
259-263: General Settings Labels Updated
In the"pages" → "settings" → "general"section, the entries"selectLanguage"and"selectTimezone"are now in English. Ensure these modifications are in line with your intended updates.apps/mail/locales/de.json (4)
119-127: Thread Display Translations Updated
Within the"threadDisplay"block, keys such as"moveToSpam","markAsUnread","markAsRead","muteThread", and"favourites"have been updated to English. Please verify that these changes meet the desired localization strategy for the German interface.
188-193: New Settings Section Added
A new"settings"section has been introduced with the keys"notFound","saved","failedToSave", and"languageChanged", all in English. Please confirm that this consistency is acceptable for the German locale.
195-224: New Mail Action Entries in German
The"mail"block now includes additional keys using English text—such as"reply","replyAll","forward","labels","createNewLabel", and"noLabelsAvailable". Verify that these entries are correct and that no localized German translations are expected at this time.
259-263: General Settings Labels Updated
The"selectLanguage"and"selectTimezone"entries in the"pages" → "settings" → "general"section are now in English. Please ensure these changes align with the overall localization update for German.apps/mail/locales/ja.json (1)
188-193: Addition of the Settings Section
A new"settings"section has been added with keys"notFound","saved","failedToSave", and"languageChanged". This change expands the localization coverage for settings-related messages. Make sure that the placeholder{locale}is used consistently across all language files and that these strings align with the intended UI experience.apps/mail/locales/pt.json (2)
188-193: Introduction of the Settings Section
A new"settings"block is added with messages like"Settings not found","Settings saved", etc. Ensure that the placeholder{locale}and the chosen phrasing are consistent with the messaging in other language files and with the overall application UX.
218-223: Addition of New Mail Action Entries
New keys for mail actions ("reply","replyAll","forward","labels","createNewLabel", and"noLabelsAvailable") appear in English. Please verify that the decision to use English for these entries is deliberate and that it harmonizes with the broader design guidelines.apps/mail/locales/lv.json (2)
119-126: Standardization of Thread Display Actions in Latvian Localization
The "threadDisplay" section now displays"moveToSpam","markAsUnread", and"markAsRead"in English along with"muteThread"and"favourites". Confirm that this change is consistent with the update across locales and that it meets the expectations for Latvian users, who might otherwise expect fully localized text.
188-193: New Settings Section Added
The addition of the"settings"block—with keys such as"notFound","saved","failedToSave", and"languageChanged"—ensures that settings-related messages are now covered. Please ensure that the placeholder{locale}is correctly formatted and that the English wording is acceptable within your localization strategy for Latvian.apps/mail/locales/fr.json (2)
188-193: Introduction of the Settings Section
A new"settings"section has been introduced with entries such as"Settings not found","Settings saved","Failed to save settings", and"Language changed to {locale}". Ensure that integrating these English messages into the French localization is consistent with the overall standardization initiative and that it does not conflict with user expectations.
195-223: Addition of New Mail Action Entries
Under the"mail"section, several new action keys have been added (including"reply","replyAll","forward","labels","createNewLabel", and"noLabelsAvailable") with English wording. Please review these changes to ensure consistency with UI design standards and that using English here is a deliberate decision across languages.
2 participants
Summary by CodeRabbit
New Features
Style