Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThis pull request introduces updates to multiple localization files for the mail application, adding new key-value pairs for the terms "loading" and "loadMore" across various languages. These additions enhance the user interface by providing necessary feedback during loading operations and enabling pagination features. No changes were made to exported or public entities. Changes
Possibly related PRs
Suggested reviewers
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (24)
apps/mail/locales/lv.json (2)
14-15: Ensure proper localization for new actions keys.
The new keys"refresh": "Refresh"and"loading": "Loading..."are currently left in English even though the rest of the file is fully localized to Latvian. Please confirm if these values should be updated to their Latvian equivalents (for example,"refresh"might become"Atjaunot"or"Atsvaidzināt"and"loading"maybe"Ielādē...").
232-233: Localize the pagination prompt.
The"loadMore": "Load more"key in the"mail"section remains in English. For consistency with the rest of the Latvian text (e.g."Nav pieejamas iezīmes"), consider using a localized string such as"Ielādēt vairāk".apps/mail/locales/ca.json (2)
14-15: Review language consistency for new UI keys.
In this Catalan localization file, the new keys"refresh": "Refresh"and"loading": "Loading..."are still in English, yet other entries (like"Tanca la sessió") are well localized. Please update these to Catalan equivalents (for example,"Actualitza"for refresh and"Carregant..."for loading) if translations are available.
232-233: Translate the pagination key.
The added entry"loadMore": "Load more"in the"mail"section should likely be rendered in Catalan (e.g."Carrega'n més"). Please double-check and update accordingly.apps/mail/locales/pl.json (2)
14-15: Verify localization completeness for Polish.
The keys"refresh": "Refresh"and"loading": "Loading..."appear in English even though this file is expected to be localized into Polish. If this file should indeed be translated, consider using Polish strings such as"Odśwież"for refresh and"Ładowanie..."for loading.
232-233: Check consistency in pagination text.
The"loadMore": "Load more"string is also still in English. In the Polish context, a proper translation might be"Załaduj więcej". Please verify and update if needed.apps/mail/locales/cs.json (2)
14-15: Align new keys with Czech localization standards.
The new keys"refresh": "Refresh"and"loading": "Loading..."are left in English whereas the rest of the file is in Czech. Please update these entries with appropriate Czech translations (for example,"Obnovit"for refresh and"Načítání..."for loading).
232-233: Localize the pagination string.
Similarly, the"loadMore": "Load more"entry in the"mail"section should be updated to a Czech equivalent (such as"Načíst další").apps/mail/locales/hi.json (1)
14-15: Ensure Hindi translations for new actions keys.
The new keys"refresh": "Refresh"and"loading": "Loading..."are still in English in the"common.actions"block. To maintain a consistent user experience in Hindi, please verify if these should be translated (for instance,"refresh"could be rendered as"ताज़ा करें"and"loading"as"लोड हो रहा है...").apps/mail/locales/ru.json (2)
14-15: Untranslated Interface Strings incommon.actions
The new keys"refresh"and"loading"have been added with English values ("Refresh" and "Loading..."). In a Russian localization file, you might consider using Russian phrases (for example,"Обновить"and"Загрузка...") unless these are intentionally left in English as placeholders.
232-233: Inconsistent Localization in
The"loadMore"key (added after"noLabelsAvailable") currently uses the English string "Load more". Given that the rest of the translations in this file are in Russian, please verify whether a proper Russian translation (e.g."Загрузить больше") should be used.apps/mail/locales/pt.json (2)
14-15: Placeholder Strings in Portuguese Locale
The newly added keys"refresh"and"loading"remain in English ("Refresh" and "Loading..."). For the Portuguese localization, consider using the appropriate translations (for instance,"Atualizar"and"Carregando...") if final translations are available.
232-233: Translation Consistency in
The"loadMore"key is introduced with the English value "Load more". Please confirm whether this should be localized for the Portuguese locale (e.g."Carregar mais").apps/mail/locales/de.json (2)
14-15: English Strings in German Localization
The changes add"refresh": "Refresh"and"loading": "Loading..."under the"actions"section. In a German locale file, these values would typically be localized (for example,"Aktualisieren"and"Lädt..."). Please verify if these English placeholders are intentional.
232-233: Potential Localization Update in
The new"loadMore"key appears with the value "Load more". For a German user interface, consider an update to a German equivalent (such as"Mehr laden") if a translation is available.apps/mail/locales/ja.json (2)
14-15: Review of New Keys in Japanese Locale
In the"common.actions"section, the keys"refresh"and"loading"now have English values ("Refresh" and "Loading..."). Typically, Japanese localization would use native terms (for instance,"更新"for refresh and"読み込み中..."for loading). Please confirm whether these are intended placeholders or if they need full translation.
232-233: Check Translation for Pagination Text
The new"loadMore"key in the"mail"section is set as "Load more". For Japanese users, consider updating this to a native phrase (such as"さらに表示"or a similar translation) for consistency.apps/mail/locales/ar.json (1)
14-15: Arabic Locale: Verify English Placeholders
In the"common.actions"section, the keys"refresh"and"loading"are added with the English values "Refresh" and "Loading...". Since this file is meant for Arabic translations, please double-check if these should be replaced with their Arabic equivalents (for example,"تحديث"and"جار التحميل") or left as-is temporarily.apps/mail/locales/tr.json (2)
14-15: Verify Turkish Localization for 'loading' and 'refresh'
The keys"refresh"and"loading"in the common/actions section now use the English values"Refresh"and"Loading...". Please confirm if these are intentionally left untranslated or if they should be updated to Turkish (for example,"Yenile"and"Yükleniyor...") to ensure a consistent localized experience.
232-233: Ensure Consistent Turkish Translations in the Mail Section
The new key"loadMore"is added with the value"Load more", and the existing"noLabelsAvailable"remains in English. To maintain consistency across the Turkish locale, please update these values to appropriate Turkish translations.apps/mail/locales/ko.json (2)
14-15: Verify Korean Localization for 'loading' and 'refresh'
In the common/actions section, the keys"refresh"and"loading"are set to"Refresh"and"Loading..."respectively. These values are still in English. Please confirm whether these should be translated (for example,"새로고침"and"로딩 중...") to fully localize the interface for Korean users.
232-233: Update the 'loadMore' Translation in the Mail Section
The new key"loadMore"currently has the English value"Load more". For a seamless Korean user experience, please consider providing the proper Korean translation.apps/mail/locales/es.json (2)
14-15: Correct the Spanish Translation for the 'loading' Key
In the common/actions section,"refresh"has been correctly updated to"Actualizar", but"loading"remains as"Loading..."in English. Please update this key to its equivalent Spanish translation (for example,"Cargando...") to ensure consistency.
232-233: Update the 'loadMore' Key Translation in the Mail Section
The new"loadMore"key is defined with the value"Load more"in English, whereas according to the PR summary it should likely be translated into Spanish (e.g.,"Cargar más"). Please update the value accordingly.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (14)
apps/mail/locales/ar.json(2 hunks)apps/mail/locales/ca.json(2 hunks)apps/mail/locales/cs.json(2 hunks)apps/mail/locales/de.json(2 hunks)apps/mail/locales/es.json(5 hunks)apps/mail/locales/fr.json(2 hunks)apps/mail/locales/hi.json(2 hunks)apps/mail/locales/ja.json(2 hunks)apps/mail/locales/ko.json(2 hunks)apps/mail/locales/lv.json(2 hunks)apps/mail/locales/pl.json(2 hunks)apps/mail/locales/pt.json(2 hunks)apps/mail/locales/ru.json(2 hunks)apps/mail/locales/tr.json(2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- apps/mail/locales/fr.json
2 participants
Summary by CodeRabbit