Update German translations#544
Update German translations#544LuggaPugga wants to merge 2 commits intoMail-0:stagingfrom LuggaPugga:german_translations
Conversation
|
@LuggaPugga is attempting to deploy a commit to the Zero Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThis pull request updates the German localization file ( Changes
Possibly related PRs
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (4)
apps/mail/locales/de.json (4)
138-167: Notes Section – Core Labels and Plurals
The main keys under the"notes"object are comprehensively translated. A couple of points to verify:
- The plural formatting for
"noteCount"uses=0 {Notizen hinzufügen}which might be interpreted as a call-to-action rather than a simple numeric display. Please confirm this is intentional.- For
"noteUnpinned", the translation"Notiz gelöst"might be a bit ambiguous; consider if an alternative such as"Notiz lösen"better conveys the unpinning action.
189-194: Notes Section – Action Translations
Action labels such as"pin","unpin","edit","delete","copy", and"changeColor"are translated appropriately. Reconsider the phrasing for"unpin"—using"Notiz lösen"might be more immediately understandable than"Notiz gelöst".
204-232: Mail Section – General Email Labels
The email-related keys are well translated. One minor point: the key"deselectAll"is rendered as"Alle E-Mails deaktivieren".
Consider verifying if a term like"Auswahl aufheben"might more precisely communicate the action of removing a selection, in line with user expectations.
308-308: Appearance Section – Missing Inbox Type
The key"inboxType"is currently empty. If this is intentional for design purposes, it’s acceptable; otherwise, please consider adding a default or placeholder translation to avoid potential confusion.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
apps/mail/locales/de.json(9 hunks)
🔇 Additional comments (15)
apps/mail/locales/de.json (15)
14-15: Translation Consistency in Common Actions
The labels for"refresh"and"loading"have been updated to"Aktualisieren"and"Laden..."respectively. These translations are clear and align well with standard UI terminology.
70-75: Enhanced AI and Search Bar Translations
The new keys under the search bar—such as"searching","aiSuggestions","aiSearching","aiSearchError","aiNoResults", and"aiEnhancedQuery"—are well translated. They accurately reflect the intended user messages in German.
97-101: Reply Compose Section Updates
The ICU-based pluralization in"attachmentCount"and"fileCount"is appropriately implemented. The"forward"action is also consistently translated as"Weiterleiten", matching similar terminology elsewhere in the file.
114-120: Mail Display Unsubscribe Translations
The updates for unsubscribe-related labels (e.g."unsubscribe","unsubscribed","unsubscribeDescription","unsubscribeOpenSiteDescription","cancel","goToWebsite", and"failedToUnsubscribe") are clear and user-friendly.
128-132: Thread Display Action Labels
Translations for thread actions—namely"moveToSpam","markAsUnread","markAsRead", and"favourites"—are consistent. The terminology is clear; just ensure that the chosen words match the overall tone of your application.Also applies to: 135-135
169-176: Notes Section – Error Messages
All error messages under"errors"(e.g."failedToLoadNotes","failedToLoadThreadNotes", etc.) are clearly translated and provide concise feedback to the user.
178-186: Notes Section – Color Names
The color translations under"colors"are accurate and descriptive. They maintain consistency with common German color terminology.
198-201: Settings Translations
The translations for settings-related messages ("notFound","saved","failedToSave", and"languageChanged") are correctly localized and straightforward.
244-244: Sidebar Navigation Update
The"contact"label is now translated as"Kontakt", which is clear and correct.
252-252: Navigation Settings – Shortcuts Label
The translation for"shortcuts"as"Tastenkürzel"fits well within the overall UI terminology.
269-279: Pages > Settings > General Section
Updates like"selectLanguage","selectTimezone","dynamicContentDescription","externalImagesDescription","languageChangedTo","customPrompt","customPromptPlaceholder", and"customPromptDescription"are accurate and enhance clarity for users configuring the app.
284-285: Pages > Settings > Connections
The disconnect-related keys ("disconnectTitle"and"disconnectDescription") are clearly and appropriately translated.
297-302: Pages > Settings > Security Section
The security texts, including the descriptions for two-factor authentication and login notifications, have been updated to provide clear guidance. These translations maintain a consistent and reassuring tone.
311-334: Pages > Settings > Shortcuts Section
The translations under shortcuts (action labels like"newEmail","sendEmail","reply", etc.) are concise and consistent. They provide clear guidance for user interactions.
341-345: Pages > Create Email Section Updates
The updates in the create email page—the translations for"attachments","dropFilesToAttach","writeYourMessageHere","emailSentSuccessfully", and"failedToSendEmail"—are clear and enhance user comprehension during email composition.
|
Oh, sorry, I didn't see the Crowdin link. |
|
I sent the request to edit in it |
Accepted, please read our translation guide |
|
On it, thank you. |
2 participants
READ CAREFULLY THEN REMOVE
Remove bullet points that are not relevant.
PLEASE REFRAIN FROM USING AI TO WRITE YOUR CODE AND PR DESCRIPTION. IF YOU DO USE AI TO WRITE YOUR CODE PLEASE PROVIDE A DESCRIPTION AND REVIEW IT CAREFULLY. MAKE SURE YOU UNDERSTAND THE CODE YOU ARE SUBMITTING USING AI.
Description
Updated German locales for completion and readability.
Type of Change
Please delete options that are not relevant.
Areas Affected
Please check all that apply:
Testing Done
Describe the tests you've done:
Security Considerations
For changes involving data or authentication:
Checklist
Screenshots/Recordings
Add screenshots or recordings here if applicable.
By submitting this pull request, I confirm that my contribution is made under the terms of the project's license.
Summary by CodeRabbit