Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove translations of previously modified string #276

Closed
wants to merge 1 commit into from
Closed

Remove translations of previously modified string #276

wants to merge 1 commit into from

Conversation

lucasmz-dev
Copy link

The 'New releases album' string was modified without removing the translations which still mentioned them.

  • A few here weren't removed because they've been updated recently or have obviously never mentioned albums

This should be done for the purpose of maintaining strings properly so that this project can properly integrate with translation solutions like Weblate for instance

@lucasmz-dev
Copy link
Author

lucasmz-dev commented Jul 31, 2024

This change would ideally also be bundled (well, replaced) with renaming the other side of the string... (the ID?) I don't know how to do that though. This is fine though. I'd just help with accidental merging.

@lucasmz-dev lucasmz-dev mentioned this pull request Aug 5, 2024
@lucasmz-dev
Copy link
Author

Rebased; added back french translation as it seems to only mention 'new releases'

@lucasmz-dev lucasmz-dev mentioned this pull request Aug 7, 2024
3 tasks
The 'New releases album' string was modified without removing the translations which still mentioned them

* A few here weren't removed because they've been updated recently or have obviously never mentioned albums
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant