-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update strings.xml #287
Update strings.xml #287
Conversation
Updated Italian translation * Added some missing keys * Translated some untranslated strings * Changed some translations * One key cannot be translated ("filter_bookmarked") as I don't know the context
</plurals> | ||
|
||
<!-- Home --> | ||
<string name="history">Cronologia</string> | ||
<string name="stats">Statistiche</string> | ||
<string name="mood_and_genres">Mood e generi</string> | ||
<string name="account">Account</string> | ||
<string name="account">Profilo</string> | ||
<string name="quick_picks">Scelte rapide</string> | ||
<string name="quick_picks_empty">Ascolta alcuni brani per generare le tue scelte rapide</string> | ||
<string name="new_release_albums">Nuovi album in uscita</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update new_release_albums to not mention albums? Check the English string.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should have fixed this, @lucasmz-dev
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DW it wasn't highlighted properly hence why #276 exists, but it's nice to highlight so that you don't have to do this again later :P
As suggested by @lucasmz-dev I removed the direct mention to albums in a string
Weird thing it didn't crashed on the PR test, I'll fix that if you could give me the equivalent in Italian, or I'll use my Italian 101 x) |
@Malopieds I don't understand what should I translate. Anyway, in Italian language, the singular form of the sentence is "1 elemento" and the plural is "n elementi" |
* Update strings.xml Updated Italian translation * Added some missing keys * Translated some untranslated strings * Changed some translations * One key cannot be translated ("filter_bookmarked") as I don't know the context * Update Italian strings.xml As suggested by @lucasmz-dev I removed the direct mention to albums in a string
Updated Italian translation