update aws-sdk gem to v3

[AlexanderZagaynov]

This is a part of global update aws-sdk gem to v3

Together with:

• update aws-sdk gem to v3 manageiq-providers-amazon#488
• require specific aws gems manageiq#19411
• update aws-sdk gem to v3 manageiq-gems-pending#449

It should fix ManageIQ/manageiq-providers-amazon#465

[miq-bot]

Checked commits AlexanderZagaynov/amazon_ssa_support@5c11949~...e8dbbed with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
11 files checked, 0 offenses detected
Everything looks fine. 👍

[AlexanderZagaynov]

All tests are green on my machine with patched versions of all gems mentioned here.

[agrare]

@roliveri @hsong-rh can you review?

[roliveri]

@AlexanderZagaynov Do we know the cause of the Travis failure?

[agrare]

@roliveri I assume it is because not all of the dependent PRs have been merged (e.g. gems-pending still requires < 3.0)

[roliveri]

I'm sure it's correct, but could you explain: we're updating the aws-sdk gem to v3, yet we're adding dependancies to its constituent gems ~> 1.0. Is that correct?

Plus, do the related PRs need to be merged in any specific order?

[AlexanderZagaynov]

@roliveri @agrare yes, all PRs should me merged at once. I've tested them all locally and fixed issues found, so I believe travis will be green after merge. About v1 - yes, it's right, you can check all dependent gems versions here:
https://rubygems.org/gems/aws-sdk/versions/3.0.1 -> https://rubygems.org/gems/aws-sdk-resources -> ...

[agrare]

@roliveri once you approve this I can merge the other PRs but I'm not a merger here so I'll need you to merge it

[roliveri]

@agrare Let me know when you want me to merge this.

[agrare]

@roliveri merge away, core PRs have been merged

[agrare]

@roliveri upstream/hammer for manageiq core is failing because it pulls in amazon_ssa_support master (https://travis-ci.org/ManageIQ/manageiq/builds/600935466#L373-L382).
Can we either version and release this properly or add release branches (hammer/ivanchuk/master) ?

[agrare]

cc @simaishi ^

[roliveri]

Should we just create a hammer branch before this merge? I've been out of git for a while, not sure how to do that.

[simaishi]

Can we either version and release this properly or add release branches (hammer/ivanchuk/master) ?

Or maybe we can just tag? This blocks today's downstream build...

cc @Fryguy

[himdel]

Looks like this PR breaks in gaprindashvili:
gitter ☝️ October 22, 2019 12:03 PM