update aws-sdk gem to v3

[AlexanderZagaynov]

This is a part of global update aws-sdk gem to v3

Together with:

• update aws-sdk gem to v3 manageiq-providers-amazon#488
• require specific aws gems manageiq#19411
• update aws-sdk gem to v3 amazon_ssa_support#44

It should fix ManageIQ/manageiq-providers-amazon#465

[miq-bot]

Checked commits AlexanderZagaynov/manageiq-gems-pending@5086ae5~...f0a5d5a with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. ⭐

[djberg96]

Huh, 2.5 passed, but 2.4 failed. Maybe restart Travis on this one, see what happens.

[AlexanderZagaynov]

yeah, some timeout issue, however I have no control to restart it...

[djberg96]

@AlexanderZagaynov Neither can I. You can do the old "close and reopen" trick, I think that will kick it.

[NickLaMuro]

This is the only PR I think I had where I would have any stake in the matter. I would like to run some automated tests I had around this code, so I am going to do that first before officially approving, but I think what you have here makes sense to start.

I think long term, I would like to move these changes to be something that is included with a provider plugin instead of living in this repo, but that is a longer discussion to be had, and we should do that in a separate effort after this.

Will respond again once I can test DB backups with this change.

[djberg96]

@NickLaMuro What specifically is at stake? Anything we can help with?

[agrare]

Provider tests are green with this applied

[NickLaMuro]

@djberg96 I think it is fine that this is merged without me testing (sorry... computer swapping all day), but this is your question:

@NickLaMuro What specifically is at stake? Anything we can help with?

It is currently being used for here:

https://github.com/ManageIQ/manageiq-gems-pending/blob/master/lib/gems/pending/util/object_storage/miq_s3_storage.rb

Which, as you probably can imagine, has zero unit tests around the database backup code for this. Also, we are streaming the data from the backup directly to S3, which makes it complicated. That said, what was here previously was a patch of a direct port of what existed in v3 that should work just fine.

That said, I haven't had a chance to run through my test suite of this yet, since I honestly have missed placed where I have configured it, but the test suite is basically here:

https://gist.github.com/NickLaMuro/8438015363d90a2d2456be650a2b9bc6

That said, getting that repo ("test suite") up and running is no easy task, so I just need to find some time to update things and make sure this new code works with the s3 tests still. On my TODO list...