Simplify the records iterator #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since everything is targeted, this is not used anymore.
And simplify the iterator, since we use just one branch now
To make sure we test all posibilities, we should test serialized and deserialized persister
That should be enough for comparing changes and we will still able to evaluate equality.
Ladas
changed the title
Ladas
changed the title
Ladas
force-pushed
the
simplify_the_records_iterator
branch
from
1f44fca
to
30be1d4
Compare
1 task
agrare
reviewed
Apr 16, 2019
| @@ -2,19 +2,11 @@ module InventoryRefresh | |||
| class ApplicationRecordIterator | |||
| attr_reader :inventory_collection, :manager_uuids_set, :iterator, :query | |||
There was a problem hiding this comment.
@Ladas can @manager_uuids_set be deleted now?
There was a problem hiding this comment.
Actually are any of these ivars still used?
|
Checked commits Ladas/inventory_refresh@86bf292~...604cd07 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 lib/inventory_refresh/inventory_collection.rb
spec/persister/parallel_saving_spec.rb
spec/persister/sweep_inactive_records_spec.rb
|
agrare
approved these changes
Apr 16, 2019
d-m-u
added a commit
to d-m-u/inventory_refresh
that referenced
this pull request
Jun 29, 2020
more core ext's on 4.1.0 update for update sake https://github.com/ManageIQ/more_core_extensions/compare/179bf40..e5b4501 - Added Ruby 2.7 support [[ManageIQ#79](ManageIQ/more_core_extensions#79)] - Added Process#pause, Process#resume, and Process#alive? [[ManageIQ#73](ManageIQ/more_core_extensions#73)] array added * `#compact_map` - Collect non-nil results from the block array added `#tabular_sort` - Sorts an Array of Hashes by specific columns hierarchy added `#descendant_get` - Returns the descendant with a given name the two breaking changes: - **BREAKING**: Moved Object#descendant_get to Class#descendant_get [[ManageIQ#75](ManageIQ/more_core_extensions#75)] - **BREAKING**: Removed deprecated Enumerable#stable_sort_by [[ManageIQ#76](ManageIQ/more_core_extensions#76)] a minor header output change was made that hasn't been released yet to make tableize more markdown compliant see ManageIQ/linux_admin#221
d-m-u
added a commit
to d-m-u/inventory_refresh
that referenced
this pull request
Jul 14, 2020
more core ext's on 4.1.0 update for update sake https://github.com/ManageIQ/more_core_extensions/compare/179bf40..e5b4501 - Added Ruby 2.7 support [[ManageIQ#79](ManageIQ/more_core_extensions#79)] - Added Process#pause, Process#resume, and Process#alive? [[ManageIQ#73](ManageIQ/more_core_extensions#73)] array added * `#compact_map` - Collect non-nil results from the block array added `#tabular_sort` - Sorts an Array of Hashes by specific columns hierarchy added `#descendant_get` - Returns the descendant with a given name the two breaking changes: - **BREAKING**: Moved Object#descendant_get to Class#descendant_get [[ManageIQ#75](ManageIQ/more_core_extensions#75)] - **BREAKING**: Removed deprecated Enumerable#stable_sort_by [[ManageIQ#76](ManageIQ/more_core_extensions#76)] a minor header output change was made that hasn't been released yet to make tableize more markdown compliant see ManageIQ/linux_admin#221
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the iterator and allow it to run pure sql fetch (which will cause speedup). Make sure specs with this pass with serialized format too (there was a timestamp comparing change needed to pass all specs, since the pure SQL doesn't cast the timestamp for us)