Add custom pause, resume and alive? Process methods #73

djberg96 · 2020-01-31T13:28:57Z

This PR extends the Process module to include pause, resume and alive? methods.

The Unix implementation is fairly straightforward, simply using SIGSTOP and SIGCONT. The Windows implementation was trickier, and required the use of an ffi wrapper (here I used fiddle from the standard library).

~~WIP for now until I add some specs. But, I can tell you that in local examples it worked as expected.~~

The only quirk I noticed was on Windows it would not immediately respond to an event, e.g. SIGINT, but would instead defer until the process was resumed, whereas on unixy systems it appeared to react immediately, e.g. you could ctrl-c out of a paused process. But, I couldn't tell you if one of these is more "correct" than the other.

The ultimate goal is to remove the custom MiqProcess module from gems-pending.

Fryguy

LGTM

Can you please also update the README?

Fryguy · 2020-01-31T14:31:13Z

@bdunne Thoughts?

lib/more_core_extensions/core_ext/process/pause_resume.rb

djberg96 · 2020-01-31T14:44:36Z

@Fryguy ok, updated readme.

NickLaMuro

2 cents

lib/more_core_extensions/core_ext/process/pause_resume.rb

Fryguy · 2020-01-31T20:13:10Z

Looks good @djberg96 ... I think we are just waiting on specs.

NickLaMuro

Really neat seeing what you are able to do with Fiddle 😍

djberg96 · 2020-01-31T21:17:42Z

@Fryguy, @NickLaMuro suggestions for testing an external process?

NickLaMuro · 2020-01-31T21:43:57Z

suggestions for testing an external process?

🤔

This is the best I can come up with at the moment...

Spawn a process that is basically a loop that writes to a log every few ticks
- probably can just be another ruby process with %x[#{Gem.ruby} -e "loop; ...; end"]
wait a bit (sleep)
Check the process is .alive?
.pause the process and check how many lines were written
wait a bit
read the log file again and check again that the lines still match
.resume the process
wait a bit
confirm new lines have been written
kill the process

djberg96 · 2020-02-01T01:17:51Z

@NickLaMuro I don't know if it's an option, but I did see this: https://github.com/jpastuszek/rspec-background-process

Rename file, add file to all.rb. Add Process info to README.md. Use Gem.win_platform? to check for Windows. Define method once depending on platform. Initial attempt to add specs, add sys-proctable dev dependency. Add some initial pause specs. Add more pause specs. Use helper method, temporary specs for resume method. Cleanup resume specs. Make Windows version align with Unixy version.

djberg96 · 2020-02-07T14:13:13Z

@NickLaMuro Ok, I've add some specs, please let me know what you think.

Note that while I did insert some code to make the Windows version cross-platform, the current specs do not currently pass on Windows. This is because getting process status information on Windows is more difficult.

There is a status field in the Win32_Process object, but unfortunately it's always null (as per the documentation). On Windows you can't get process status, you can only get thread status. While it's possible to get this information, it would require adding more code to sys-proctable, which I don't want to worry about right now, especially since Windows doesn't matter to us atm.

djberg96 · 2020-02-08T00:02:42Z

@miq-bot remove_label wip

djberg96 · 2020-02-10T14:23:27Z

@NickLaMuro, @Fryguy, @jrafanie I think it's ready to go. :)

NickLaMuro

Had one comment, but it is mostly a clarification and not a deal breaker, so I think I am good with this.

NickLaMuro · 2020-02-10T16:06:10Z

spec/core_ext/process/pause_resume_spec.rb

+  end
+
+  def paused_status
+    linux ? 'T' : 4


So, is 4 the status is the paused status for Windows or macOS? (or both?)

If it isn't both, does that mean these specs can't run on one of those operating systems?

Just Mac. As per my previous comment, these specs will not currently pass on Windows because I can't currently get a process status to verify that it's paused or not. But, since we're not explicitly supporting Windows I was hoping you would let that slide for now.

NickLaMuro · 2020-02-10T16:06:23Z

spec/core_ext/process/pause_resume_spec.rb

+
+  context ".pause" do
+    before do
+      @pid = Process.spawn(Gem.ruby, "-esleep 3 while true")


lib/more_core_extensions/core_ext/process/pause_resume.rb

bdunne

👍 One minor nit, but this looks great!

miq-bot · 2020-02-13T17:05:16Z

Checked commits https://github.com/djberg96/more_core_extensions/compare/e8f0676bf9e36b3955f03286bd94ed403f5d5217~...7cad6e57c775867349da5cee1bda8b7df7388f00 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.20.0, and yamllint
4 files checked, 3 offenses detected

spec/core_ext/process/pause_resume_spec.rb

❗ - Line 21, Col 29 - Style/NumericLiterals - Use underscores(_) as thousands separator and separate every 3 digits with them.
❗ - Line 43, Col 28 - Style/NumericLiterals - Use underscores(_) as thousands separator and separate every 3 digits with them.
❗ - Line 70, Col 29 - Style/NumericLiterals - Use underscores(_) as thousands separator and separate every 3 digits with them.

Added - Added Ruby 2.7 support [[#79](#79)] - Added Process#pause, Process#resume, and Process#alive? [[#73](#73)]

there's no particular reason, just update for update sake https://github.com/ManageIQ/more_core_extensions/compare/179bf40..e5b4501 - Added Ruby 2.7 support [[ManageIQ#79](ManageIQ/more_core_extensions#79)] - Added Process#pause, Process#resume, and Process#alive? [[ManageIQ#73](ManageIQ/more_core_extensions#73)] array added * `#compact_map` - Collect non-nil results from the block array added `#tabular_sort` - Sorts an Array of Hashes by specific columns hierarchy added `#descendant_get` - Returns the descendant with a given name the two breaking changes: - **BREAKING**: Moved Object#descendant_get to Class#descendant_get [[ManageIQ#75](ManageIQ/more_core_extensions#75)] - **BREAKING**: Removed deprecated Enumerable#stable_sort_by [[ManageIQ#76](ManageIQ/more_core_extensions#76)] a minor header output change was made that hasn't been released yet to make tableize more markdown compliant see ManageIQ/linux_admin#221

more core ext's on 4.1.0 update for update sake https://github.com/ManageIQ/more_core_extensions/compare/179bf40..e5b4501 - Added Ruby 2.7 support [[ManageIQ#79](ManageIQ/more_core_extensions#79)] - Added Process#pause, Process#resume, and Process#alive? [[ManageIQ#73](ManageIQ/more_core_extensions#73)] array added * `#compact_map` - Collect non-nil results from the block array added `#tabular_sort` - Sorts an Array of Hashes by specific columns hierarchy added `#descendant_get` - Returns the descendant with a given name the two breaking changes: - **BREAKING**: Moved Object#descendant_get to Class#descendant_get [[ManageIQ#75](ManageIQ/more_core_extensions#75)] - **BREAKING**: Removed deprecated Enumerable#stable_sort_by [[ManageIQ#76](ManageIQ/more_core_extensions#76)] a minor header output change was made that hasn't been released yet to make tableize more markdown compliant see ManageIQ/linux_admin#221

more core ext's on 4.1.0 update for update sake https://github.com/ManageIQ/more_core_extensions/compare/179bf40..e5b4501 - Added Ruby 2.7 support [[ansible#79](ManageIQ/more_core_extensions#79)] - Added Process#pause, Process#resume, and Process#alive? [[ansible#73](ManageIQ/more_core_extensions#73)] array added * `#compact_map` - Collect non-nil results from the block array added `#tabular_sort` - Sorts an Array of Hashes by specific columns hierarchy added `#descendant_get` - Returns the descendant with a given name the two breaking changes: - **BREAKING**: Moved Object#descendant_get to Class#descendant_get [[ansible#75](ManageIQ/more_core_extensions#75)] - **BREAKING**: Removed deprecated Enumerable#stable_sort_by [[ansible#76](ManageIQ/more_core_extensions#76)] a minor header output change was made that hasn't been released yet to make tableize more markdown compliant see ManageIQ/linux_admin#221

more core ext's on 4.1.0 update for update sake https://github.com/ManageIQ/more_core_extensions/compare/179bf40..e5b4501 - Added Ruby 2.7 support [[ManageIQ#79](ManageIQ/more_core_extensions#79)] - Added Process#pause, Process#resume, and Process#alive? [[ManageIQ#73](ManageIQ/more_core_extensions#73)] array added * `#compact_map` - Collect non-nil results from the block array added `#tabular_sort` - Sorts an Array of Hashes by specific columns hierarchy added `#descendant_get` - Returns the descendant with a given name the two breaking changes: - **BREAKING**: Moved Object#descendant_get to Class#descendant_get [[ManageIQ#75](ManageIQ/more_core_extensions#75)] - **BREAKING**: Removed deprecated Enumerable#stable_sort_by [[ManageIQ#76](ManageIQ/more_core_extensions#76)] a minor header output change was made that hasn't been released yet to make tableize more markdown compliant see ManageIQ/linux_admin#221

update for update sake https://github.com/ManageIQ/more_core_extensions/compare/179bf40..e5b4501 - Added Ruby 2.7 support [[ManageIQ#79](ManageIQ/more_core_extensions#79)] - Added Process#pause, Process#resume, and Process#alive? [[ManageIQ#73](ManageIQ/more_core_extensions#73)] array added * `#compact_map` - Collect non-nil results from the block array added `#tabular_sort` - Sorts an Array of Hashes by specific columns hierarchy added `#descendant_get` - Returns the descendant with a given name the two breaking changes: - **BREAKING**: Moved Object#descendant_get to Class#descendant_get [[ManageIQ#75](ManageIQ/more_core_extensions#75)] - **BREAKING**: Removed deprecated Enumerable#stable_sort_by [[ManageIQ#76](ManageIQ/more_core_extensions#76)] a minor header output change was made that hasn't been released yet to make tableize more markdown compliant see ManageIQ/linux_admin#221

more core ext's on 4.1.0 update for update sake https://github.com/ManageIQ/more_core_extensions/compare/179bf40..e5b4501 - Added Ruby 2.7 support [[ManageIQ#79](ManageIQ/more_core_extensions#79)] - Added Process#pause, Process#resume, and Process#alive? [[ManageIQ#73](ManageIQ/more_core_extensions#73)] array added * `#compact_map` - Collect non-nil results from the block array added `#tabular_sort` - Sorts an Array of Hashes by specific columns hierarchy added `#descendant_get` - Returns the descendant with a given name the two breaking changes: - **BREAKING**: Moved Object#descendant_get to Class#descendant_get [[ManageIQ#75](ManageIQ/more_core_extensions#75)] - **BREAKING**: Removed deprecated Enumerable#stable_sort_by [[ManageIQ#76](ManageIQ/more_core_extensions#76)] a minor header output change was made that hasn't been released yet to make tableize more markdown compliant see ManageIQ/linux_admin#221

update for update sake https://github.com/ManageIQ/more_core_extensions/compare/179bf40..e5b4501 - Added Ruby 2.7 support [[ManageIQ#79](ManageIQ/more_core_extensions#79)] - Added Process#pause, Process#resume, and Process#alive? [[ManageIQ#73](ManageIQ/more_core_extensions#73)] array added * `#compact_map` - Collect non-nil results from the block array added `#tabular_sort` - Sorts an Array of Hashes by specific columns hierarchy added `#descendant_get` - Returns the descendant with a given name the two breaking changes: - **BREAKING**: Moved Object#descendant_get to Class#descendant_get [[ManageIQ#75](ManageIQ/more_core_extensions#75)] - **BREAKING**: Removed deprecated Enumerable#stable_sort_by [[ManageIQ#76](ManageIQ/more_core_extensions#76)] a minor header output change was made that hasn't been released yet to make tableize more markdown compliant see ManageIQ/linux_admin#221

more core ext's on 4.1.0 update for update sake https://github.com/ManageIQ/more_core_extensions/compare/179bf40..e5b4501 - Added Ruby 2.7 support [[ManageIQ#79](ManageIQ/more_core_extensions#79)] - Added Process#pause, Process#resume, and Process#alive? [[ManageIQ#73](ManageIQ/more_core_extensions#73)] array added * `#compact_map` - Collect non-nil results from the block array added `#tabular_sort` - Sorts an Array of Hashes by specific columns hierarchy added `#descendant_get` - Returns the descendant with a given name the two breaking changes: - **BREAKING**: Moved Object#descendant_get to Class#descendant_get [[ManageIQ#75](ManageIQ/more_core_extensions#75)] - **BREAKING**: Removed deprecated Enumerable#stable_sort_by [[ManageIQ#76](ManageIQ/more_core_extensions#76)] a minor header output change was made that hasn't been released yet to make tableize more markdown compliant see ManageIQ/linux_admin#221

there's no particular reason, just update for update sake https://github.com/ManageIQ/more_core_extensions/compare/179bf40..e5b4501 - Added Ruby 2.7 support [[ManageIQ#79](ManageIQ/more_core_extensions#79)] - Added Process#pause, Process#resume, and Process#alive? [[ManageIQ#73](ManageIQ/more_core_extensions#73)] array added * `#compact_map` - Collect non-nil results from the block array added `#tabular_sort` - Sorts an Array of Hashes by specific columns hierarchy added `#descendant_get` - Returns the descendant with a given name the two breaking changes: - **BREAKING**: Moved Object#descendant_get to Class#descendant_get [[ManageIQ#75](ManageIQ/more_core_extensions#75)] - **BREAKING**: Removed deprecated Enumerable#stable_sort_by [[ManageIQ#76](ManageIQ/more_core_extensions#76)] a minor header output change was made that hasn't been released yet to make tableize more markdown compliant see ManageIQ/linux_admin#221

more core ext's on 4.1.0 update for update sake https://github.com/ManageIQ/more_core_extensions/compare/179bf40..e5b4501 - Added Ruby 2.7 support [[ManageIQ#79](ManageIQ/more_core_extensions#79)] - Added Process#pause, Process#resume, and Process#alive? [[ManageIQ#73](ManageIQ/more_core_extensions#73)] array added * `#compact_map` - Collect non-nil results from the block array added `#tabular_sort` - Sorts an Array of Hashes by specific columns hierarchy added `#descendant_get` - Returns the descendant with a given name the two breaking changes: - **BREAKING**: Moved Object#descendant_get to Class#descendant_get [[ManageIQ#75](ManageIQ/more_core_extensions#75)] - **BREAKING**: Removed deprecated Enumerable#stable_sort_by [[ManageIQ#76](ManageIQ/more_core_extensions#76)] a minor header output change was made that hasn't been released yet to make tableize more markdown compliant see ManageIQ/linux_admin#221

there's no particular reason, just update for update sake https://github.com/ManageIQ/more_core_extensions/compare/179bf40..e5b4501 - Added Ruby 2.7 support [[ManageIQ#79](ManageIQ/more_core_extensions#79)] - Added Process#pause, Process#resume, and Process#alive? [[ManageIQ#73](ManageIQ/more_core_extensions#73)] array added * `#compact_map` - Collect non-nil results from the block array added `#tabular_sort` - Sorts an Array of Hashes by specific columns hierarchy added `#descendant_get` - Returns the descendant with a given name the two breaking changes: - **BREAKING**: Moved Object#descendant_get to Class#descendant_get [[ManageIQ#75](ManageIQ/more_core_extensions#75)] - **BREAKING**: Removed deprecated Enumerable#stable_sort_by [[ManageIQ#76](ManageIQ/more_core_extensions#76)] a minor header output change was made that hasn't been released yet to make tableize more markdown compliant see ManageIQ/linux_admin#221

more core ext's on 4.1.0 update for update sake https://github.com/ManageIQ/more_core_extensions/compare/179bf40..e5b4501 - Added Ruby 2.7 support [[ManageIQ#79](ManageIQ/more_core_extensions#79)] - Added Process#pause, Process#resume, and Process#alive? [[ManageIQ#73](ManageIQ/more_core_extensions#73)] array added * `#compact_map` - Collect non-nil results from the block array added `#tabular_sort` - Sorts an Array of Hashes by specific columns hierarchy added `#descendant_get` - Returns the descendant with a given name the two breaking changes: - **BREAKING**: Moved Object#descendant_get to Class#descendant_get [[ManageIQ#75](ManageIQ/more_core_extensions#75)] - **BREAKING**: Removed deprecated Enumerable#stable_sort_by [[ManageIQ#76](ManageIQ/more_core_extensions#76)] a minor header output change was made that hasn't been released yet to make tableize more markdown compliant see ManageIQ/linux_admin#221

Fryguy approved these changes Jan 31, 2020

View reviewed changes

Fryguy added the enhancement label Jan 31, 2020

Fryguy assigned bdunne Jan 31, 2020

jrafanie reviewed Jan 31, 2020

View reviewed changes

lib/more_core_extensions/core_ext/process/pause_resume.rb Show resolved Hide resolved

NickLaMuro reviewed Jan 31, 2020

View reviewed changes

lib/more_core_extensions/core_ext/process/pause_resume.rb Outdated Show resolved Hide resolved

NickLaMuro approved these changes Jan 31, 2020

View reviewed changes

miq-bot added the wip label Jan 31, 2020

Use eql not equal.

e7173df

djberg96 changed the title ~~[WIP] Add custom pause, resume and alive? Process methods~~ Add custom pause, resume and alive? Process methods Feb 8, 2020

miq-bot removed the wip label Feb 8, 2020

NickLaMuro reviewed Feb 10, 2020

View reviewed changes

bdunne reviewed Feb 13, 2020

View reviewed changes

lib/more_core_extensions/core_ext/process/pause_resume.rb Show resolved Hide resolved

bdunne approved these changes Feb 13, 2020

View reviewed changes

bdunne merged commit 52d3dff into ManageIQ:master Feb 13, 2020

Fryguy added a commit that referenced this pull request Apr 30, 2020

Release v4.1.0

bd08edf

Added - Added Ruby 2.7 support [[#79](#79)] - Added Process#pause, Process#resume, and Process#alive? [[#73](#73)]

d-m-u mentioned this pull request Jun 26, 2020

bump more_core_extensions ManageIQ/linux_admin#221

Merged

d-m-u mentioned this pull request Jun 29, 2020

bump more core extension dependency ManageIQ/manageiq-providers-kubernetes#384

Merged

d-m-u mentioned this pull request Jun 29, 2020

bump more core extensions ManageIQ/manageiq-providers-openstack#610

Merged

d-m-u mentioned this pull request Jun 29, 2020

bump more core extensions ManageIQ/manageiq-schema#493

Merged

d-m-u mentioned this pull request Jun 29, 2020

bump more core extensions ManageIQ/manageiq-ui-classic#7154

Merged

d-m-u mentioned this pull request Jun 29, 2020

bump more core extensions ansible/ansible_tower_client_ruby#145

Merged

d-m-u mentioned this pull request Jun 29, 2020

bump more core extensions ManageIQ/inventory_refresh#93

Merged

d-m-u mentioned this pull request Jun 29, 2020

bump more core extensions ManageIQ/vmware_web_service#80

Merged

d-m-u mentioned this pull request Jun 29, 2020

Loosen dependency on more_core_extensions ManageIQ/manageiq#20316

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add custom pause, resume and alive? Process methods #73

Add custom pause, resume and alive? Process methods #73

djberg96 commented Jan 31, 2020 •

edited

Loading

Fryguy left a comment

Fryguy commented Jan 31, 2020

djberg96 commented Jan 31, 2020

NickLaMuro left a comment

Fryguy commented Jan 31, 2020

NickLaMuro left a comment

djberg96 commented Jan 31, 2020

NickLaMuro commented Jan 31, 2020

djberg96 commented Feb 1, 2020

djberg96 commented Feb 7, 2020

djberg96 commented Feb 8, 2020

djberg96 commented Feb 10, 2020

NickLaMuro left a comment

NickLaMuro Feb 10, 2020

djberg96 Feb 10, 2020

NickLaMuro Feb 10, 2020

bdunne left a comment

miq-bot commented Feb 13, 2020

Add custom pause, resume and alive? Process methods #73

Add custom pause, resume and alive? Process methods #73

Conversation

djberg96 commented Jan 31, 2020 • edited Loading

Fryguy left a comment

Choose a reason for hiding this comment

Fryguy commented Jan 31, 2020

djberg96 commented Jan 31, 2020

NickLaMuro left a comment

Choose a reason for hiding this comment

Fryguy commented Jan 31, 2020

NickLaMuro left a comment

Choose a reason for hiding this comment

djberg96 commented Jan 31, 2020

NickLaMuro commented Jan 31, 2020

djberg96 commented Feb 1, 2020

djberg96 commented Feb 7, 2020

djberg96 commented Feb 8, 2020

djberg96 commented Feb 10, 2020

NickLaMuro left a comment

Choose a reason for hiding this comment

NickLaMuro Feb 10, 2020

Choose a reason for hiding this comment

djberg96 Feb 10, 2020

Choose a reason for hiding this comment

NickLaMuro Feb 10, 2020

Choose a reason for hiding this comment

bdunne left a comment

Choose a reason for hiding this comment

miq-bot commented Feb 13, 2020

djberg96 commented Jan 31, 2020 •

edited

Loading