Loosen dependency on more_core_extensions #20316
Conversation
|
pretty sure that https://travis-ci.com/github/ManageIQ/manageiq-cross_repo-tests/jobs/359328681#L515 is not my fault nor related to any of this |
Gemfile
Outdated
| @@ -56,7 +56,7 @@ gem "manageiq-ssh-util", "~>0.1.1", :require => false | |||
| gem "memoist", "~>0.15.0", :require => false | |||
| gem "mime-types", "~>3.0", :path => File.expand_path("mime-types-redirector", __dir__) | |||
| gem "money", "~>6.13.5", :require => false | |||
| gem "more_core_extensions", "~>3.7" | |||
| gem "more_core_extensions", "~>4.0" | |||
There was a problem hiding this comment.
I think we should drop the version requirement here since more_core_extensions is very closely tied to manageiq-gems-pending. Most of it has been extracted from manageiq-gems-pending so the minimum version should be set there. Maybe even add a comment that the version should not be set here.
@Fryguy ^ sound reasonable?
There was a problem hiding this comment.
At that point, this wouldn't need to be marked as WIP
more core ext's on 4.1.0 update for update sake https://github.com/ManageIQ/more_core_extensions/compare/179bf40..e5b4501 - Added Ruby 2.7 support [[ManageIQ#79](ManageIQ/more_core_extensions#79)] - Added Process#pause, Process#resume, and Process#alive? [[ManageIQ#73](ManageIQ/more_core_extensions#73)] array added * `#compact_map` - Collect non-nil results from the block array added `#tabular_sort` - Sorts an Array of Hashes by specific columns hierarchy added `#descendant_get` - Returns the descendant with a given name the two breaking changes: - **BREAKING**: Moved Object#descendant_get to Class#descendant_get [[ManageIQ#75](ManageIQ/more_core_extensions#75)] - **BREAKING**: Removed deprecated Enumerable#stable_sort_by [[ManageIQ#76](ManageIQ/more_core_extensions#76)] a minor header output change was made that hasn't been released yet to make tableize more markdown compliant see ManageIQ/linux_admin#221
|
Checked commit d-m-u@5c73dcf with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint |
bdunne
changed the title
more core ext's on 4.1.0
update for update sake
https://github.com/ManageIQ/more_core_extensions/compare/179bf40..e5b4501
array added *
#compact_map- Collect non-nil results from the blockarray added
#tabular_sort- Sorts an Array of Hashes by specific columnshierarchy added
#descendant_get- Returns the descendant with a given namethe two breaking changes:
a minor header output change was made that hasn't been released yet to make tableize more markdown compliant
see ManageIQ/linux_admin#221