Transformation Mappings Read and Create

[jntullo]

Adds reads and creates of Transformation Mappings to the API:

Sample create:

POST /api/transformation_mappings
{"name": "new transformation mapping",
 "description": "clusters to clusters",
 "state": "draft",
 "transformation_mapping_items": [
     { "source": "/api/clusters/10", "destination": "/api/clusters/1" },
     { "source": "/api/clusters/11", "destination": "/api/clusters/1" },
     { "source": "/api/date_stores/12", "destination": "/api/data_stores/13" },
     { "source": "/api/data_stores/2", "destination": "/api/data_stores/13" },
     { "source": "/api/lans/2", "destination": "/api/lans/13" } 
     { "source": "/api/lans/3", "destination": "/api/lans/13" } 
   ]
}

Create will accept transformation_mapping_items as part of the request with href references to the source and destination.

A call to

GET /api/transformation_mappings

Will return all of the transformation mappings.

GET /api/transformation_mappings/:id

Will return a particular transformation mapping.

Transformation Mapping Items may be retrieved via:

GET /api/transformation_mappings/:id?attributes=transformation_mapping_items

which will return

{  
   "href":"http://localhost:3000/api/transformation_mappings/10000000000001",
   "id":"10000000000001",
   "name":"Cluster and Datastores",
   "description":"Cluster and Datastores Mapping",
   "comments":null,
   "state":"draft",
   "options":{  

   },
   "tenant_id":null,
   "created_at":"2018-02-07T16:02:39Z",
   "updated_at":"2018-02-07T16:02:39Z",
   "transformation_mapping_items":[  
      {  
         "id":"10000000000001",
         "source_id":"10000000000002",
         "source_type":"EmsCluster",
         "destination_id":"10000000000005",
         "destination_type":"EmsCluster",
         "transformation_mapping_id":"10000000000001",
         "options":{  

         },
         "created_at":"2018-02-07T16:01:44Z",
         "updated_at":"2018-02-07T16:02:39Z"
      },
      {  
         "id":"10000000000002",
         "source_id":"10000000000001",
         "source_type":"Storage",
         "destination_id":"10000000000018",
         "destination_type":"Storage",
         "transformation_mapping_id":"10000000000001",
         "options":{  

         },
         "created_at":"2018-02-07T16:05:04Z",
         "updated_at":"2018-02-07T16:05:04Z"
      }
   ]
}

Dependent upon:
ManageIQ/manageiq#16787
ManageIQ/manageiq#16947
and needs a factory

cc: @bzwei @gmcculloug

[bzwei]

@jntullo does collect_config already map for example cluster to EmsCluster?
What about the GET - where do you do the translation?

[jntullo]

@bzwei Yeah, it maps to EmsCluster, as defined in the api.yml - I forgot about the reverse translation (on GET), but I will add that in

[bzwei]

@jntullo ManageIQ/manageiq#16787 has the factory for transformation_mapping. Hope it satisfies your need.

[bzwei]

@jntullo the create example should be something like

POST /api/transformation_mappings
{"name": "new transformation mapping",
 "description": "clusters to clusters",
 "state": "draft",
 "transformation_mapping_items": [
     { "source": "/api/clusters/10", "destination": "/api/clusters/1" },
     { "source": "/api/clusters/11", "destination": "/api/clusters/1" },
     { "source": "/api/clusters/12", "destination": "/api/clusters/1" },
     { "source": "/api/clusters/2", "destination": "/api/clusters/13" } 
   ]
}

[bzwei]

@miq-bot add_label transformation

[miq-bot]

@bzwei Cannot apply the following label because they are not recognized: transformation

[bzwei]

@jntullo can you resolve the travis errors?

[abellotti]

can you add a test for when the source or destination href is bogus, i.e. /api/invalid_collection/:id, we should get a BadRequest on those. Might need a minor change to fetch_mapping_resource. Thanks.

[abellotti]

Looks good @jntullo, just an additional test needed.

[miq-bot]

Checked commit jntullo@f324edc with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🏆

[abellotti]

Thanks @jntullo for updating this. LGTM!! 👍

[himdel]

gaprindashvili: depends on ManageIQ/manageiq#16787 and ManageIQ/manageiq#16947 and ManageIQ/manageiq#16988

[simaishi]

Gaprindashvili backport details:

$ git log -1
commit 3b42f4a292d440f947d921d1919b2b87f9ceb666
Author: Alberto Bellotti <abellotti@users.noreply.github.com>
Date:   Tue Feb 20 09:56:45 2018 -0500

    Merge pull request #313 from jntullo/transformation_mappings
    
    Transformation Mappings Read and Create
    (cherry picked from commit 8772e526fe61c9c149ec36b3cc0466f0d29266d3)