Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add product features needed for v2v Transformation Mappings API #16947

Merged
merged 1 commit into from
Feb 7, 2018

Conversation

jntullo
Copy link

@jntullo jntullo commented Feb 5, 2018

Product features are needed for adding the related API for #16787

Will work on the show and create for now, but adding delete / edit product features as needed for the future.

@miq-bot assign @gtanzillo
cc: @gmcculloug @bzwei

@jntullo
Copy link
Author

jntullo commented Feb 5, 2018

@h-kataria can this also get your 👀 ?

@h-kataria
Copy link
Contributor

@jntullo one minor comment do you want to move these new features above SUI and API features so all UI features are together, other than that looks good.

@miq-bot
Copy link
Member

miq-bot commented Feb 6, 2018

Checked commit jntullo@951ee2b with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🏆

@lpichler
Copy link
Contributor

lpichler commented Feb 7, 2018

@jntullo @h-kataria will be added also some transformation mapping controller ?(I am not familiar with this feature) or no at all ? because role features are checked in UI automatically and name of role is inherited from controller name:

[controller]-[action_name]

https://github.com/ManageIQ/manageiq-ui-classic/blob/master/app/controllers/application_controller.rb#L1246

@gtanzillo gtanzillo merged commit c4a57e7 into ManageIQ:master Feb 7, 2018
@gtanzillo gtanzillo added this to the Sprint 79 Ending Feb 12, 2018 milestone Feb 7, 2018
@bzwei
Copy link
Contributor

bzwei commented Feb 8, 2018

@miq-bot add_label transformation

@miq-bot miq-bot added the v2v label Feb 8, 2018
@himdel
Copy link
Contributor

himdel commented May 21, 2018

@miq-bot add_label gaprindashvili/yes

Needed by ManageIQ/manageiq-api#313 for gaprindashvili v2v support

simaishi pushed a commit that referenced this pull request May 29, 2018
Add product features needed for v2v Transformation Mappings API
(cherry picked from commit c4a57e7)
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit a4440aa90cfb80c87de5ce504e510e072727b934
Author: Gregg Tanzillo <gtanzill@redhat.com>
Date:   Wed Feb 7 14:28:54 2018 -0500

    Merge pull request #16947 from jntullo/transformation_mapping_pf
    
    Add product features needed for v2v Transformation Mappings API
    (cherry picked from commit c4a57e7bedd492782fd8eb02f531d9d2786ef9d4)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants