Adding support for /api/containers primary collection. #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @h-kataria couldn't find the individual resource's product feature:
so just using the List. Is this something we need to add to the product features, i.e. adding a Show identifier for Containers ? Thanks. |
abellotti
force-pushed
the
support_containers
branch
from
30cbb40
to
634bc03
Compare
|
@abellotti looks like a "Show" feature is missing for Individual Container object, should have been a feature similar to https://github.com/ManageIQ/manageiq/blob/master/db/fixtures/miq_product_features.yml#L3639-L3642
|
GET /api/containers GET /api/containers/:id POST /api/containers - bulk action "query" https://bugzilla.redhat.com/show_bug.cgi?id=1549661
abellotti
force-pushed
the
support_containers
branch
from
634bc03
to
a993ae1
Compare
|
Needs ManageIQ/manageiq#17074 to be merged first for the container_show product feature. |
|
Checked commit abellotti@a993ae1 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
LGTM! 👍 |
simaishi
pushed a commit
that referenced
this pull request
Mar 7, 2018
Adding support for /api/containers primary collection. (cherry picked from commit 43def71) https://bugzilla.redhat.com/show_bug.cgi?id=1552809
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for /api/containers primary collection
GET /api/containers
GET /api/containers/:id
POST /api/containers - bulk action "query"
Requires: ManageIQ/manageiq#17074
https://bugzilla.redhat.com/show_bug.cgi?id=1549661