Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding missing Product Feature for viewing a single container #17074

Merged

Conversation

abellotti
Copy link
Member

We were missing the Product feature for container_show.

This is required for: ManageIQ/manageiq-api#332

@miq-bot
Copy link
Member

miq-bot commented Mar 1, 2018

Checked commit abellotti@841a654 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. ⭐

@h-kataria
Copy link
Contributor

looks good, can be merged once tests are green.

@h-kataria h-kataria merged commit 6dd7809 into ManageIQ:master Mar 1, 2018
@abellotti abellotti added this to the Sprint 81 Ending Mar 12, 2018 milestone Mar 2, 2018
@abellotti abellotti assigned h-kataria and unassigned gtanzillo Mar 2, 2018
simaishi pushed a commit that referenced this pull request Mar 7, 2018
…ct_feature

Adding missing Product Feature for viewing a single container
(cherry picked from commit 6dd7809)

https://bugzilla.redhat.com/show_bug.cgi?id=1552809
@simaishi
Copy link
Contributor

simaishi commented Mar 7, 2018

Gaprindashvili backport details:

$ git log -1
commit aa6f8d80c01e52c54d6f0e11bdc9fef5c50143ef
Author: Harpreet Kataria <hkataria@redhat.com>
Date:   Thu Mar 1 17:12:03 2018 -0500

    Merge pull request #17074 from abellotti/missing_container_show_product_feature
    
    Adding missing Product Feature for viewing a single container
    (cherry picked from commit 6dd7809cf4a9f6af6cd3d33222810da1d4fa49c6)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1552809

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants