Add refresh parameter to ResourceActionWorkflow initialization #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label wip |
|
Checked commit eclarizio@9b5ba75 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 app/controllers/api/service_dialogs_controller.rb
|
|
@abellotti Please review. |
|
LGTM!! 👍 |
|
Thanks, I'll let you know when we are ready to merge. We are still working through some integration tests with the related PR. |
|
@miq-bot remove_label wip @abellotti This actually needs to be merged before the related PR, and it shouldn't hurt anything if it is since the backend will just ignore the new option without the related PR, so I think you can safely merge this whenever you get a chance. |
miq-bot
changed the title
abellotti
approved these changes
Apr 26, 2018
simaishi
pushed a commit
that referenced
this pull request
Apr 27, 2018
Add refresh parameter to ResourceActionWorkflow initialization (cherry picked from commit 7c2cae6) https://bugzilla.redhat.com/show_bug.cgi?id=1572716 https://bugzilla.redhat.com/show_bug.cgi?id=1572711
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ties in with ManageIQ/manageiq#17329 and will be needed in order to distinguish
ResourceActionWorkflowinitialization calls in the backend.WIP for now, but I think this is probably how the API change will end up looking.
https://bugzilla.redhat.com/show_bug.cgi?id=1559757
https://bugzilla.redhat.com/show_bug.cgi?id=1571000