Fix for Default service dialog values not included in EVM when 'refresh_dialog_fields' action invoked #19005
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling the API directly, the
refresh
option gets set to true, and ends up making a call toload_values_into_fields
. This is fine if the API call provides the values that the field should be refreshed with, but without the values, customer was running into an issue where they had a few fields that were static and not visible to the user (so therefore just automatically filled in and ready to go) that they did not pass in to the API call in 5.9.6.5. On updating to 5.10.6.1, I believe that #17329 made the change to attempt to eliminate automate calls that were happening when calling refresh that didn't need to happen, but also this eliminated the "call" to get the static field values. Again, this is fine if the API call provides these static values in the POST request (which is what the UI does), but direct use of the API does not necessarily inform the user that they should do that.For @tinaafitz and @gtanzillo (and anyone else) to review: it should be easier to track the "main" change if you go commit by commit, since the first commit contains the "meat" of the change, the second commit just moves the
#load_dialog
method into theprivate
namespace since it's not used elsewhere and separates out the block of if/else logic into another method.@miq-bot add_reviewer @tinaafitz
@miq-bot add_reviewer @gtanzillo
@miq-bot add_label bug
@tinaafitz My apologies but I've been out of the cloudforms loop for a bit, so please add any other labels
hammer/yes
,hammer/no
(?) that this might need.Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1730813