Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for Default service dialog values not included in EVM when 'refresh_dialog_fields' action invoked #19005

Merged
merged 4 commits into from
Jul 19, 2019
Merged

Fix for Default service dialog values not included in EVM when 'refresh_dialog_fields' action invoked #19005

merged 4 commits into from
Jul 19, 2019

Commits on Jul 18, 2019

  1. Initialize static field values before loading values into the field 

    https://bugzilla.redhat.com/show_bug.cgi?id=1730813
    @eclarizio
    eclarizio committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    eb51c01 View commit details
    Browse the repository at this point in the history

  2. Refactor #load_dialog method into smaller manageable private methods 

    https://bugzilla.redhat.com/show_bug.cgi?id=1730813
    @eclarizio
    eclarizio committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    bfaff43 View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary spec 

    https://bugzilla.redhat.com/show_bug.cgi?id=1730813
    @eclarizio
    eclarizio committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    a86428f View commit details
    Browse the repository at this point in the history

  4. Rename parameter for more accurate meaning and pass false for refresh 

    https://bugzilla.redhat.com/show_bug.cgi?id=1730813
    @eclarizio
    eclarizio committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    7298e4f View commit details
    Browse the repository at this point in the history