Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GAPRINDASHVILI] Pass option to retain dialog values so they're not rerun #406

Merged
merged 1 commit into from
Jul 11, 2018
Merged

[GAPRINDASHVILI] Pass option to retain dialog values so they're not rerun #406

merged 1 commit into from
Jul 11, 2018

Conversation

d-m-u
Copy link
Contributor

@d-m-u d-m-u commented Jun 26, 2018 •
edited by simaishi
Loading

Dialogs are being run twice, once on load, once on submit, this lets us reuse the values we picked so they don't rerun on submit.

Master PR: #407
Fix for https://bugzilla.redhat.com/show_bug.cgi?id=1591427
https://bugzilla.redhat.com/show_bug.cgi?id=1595776

There's a related main PR.

It's eclarizio's code.

Also it's WIP cause it needs tests.

Related to:

ManageIQ/manageiq#17641

@d-m-u d-m-u mentioned this pull request Jun 26, 2018
Merged
@d-m-u
Copy link
Contributor Author

d-m-u commented Jun 26, 2018

@miq-bot add_label g/only
is there even such a label?
My guess is we should front-port in the near-future
@eclarizio thanks and can you 👀 please, am testing now

@miq-bot
Copy link
Member

miq-bot commented Jun 26, 2018

@d-m-u Cannot apply the following label because they are not recognized: g/only

@d-m-u d-m-u changed the title [WIP] Pass option to retain dialog values so they're not rerun [GAPRINDASHVILI] [WIP] Pass option to retain dialog values so they're not rerun Jun 26, 2018
@miq-bot miq-bot changed the title [GAPRINDASHVILI] [WIP] Pass option to retain dialog values so they're not rerun [WIP] [GAPRINDASHVILI] [WIP] Pass option to retain dialog values so they're not rerun Jun 26, 2018
@miq-bot miq-bot added the wip label Jun 26, 2018
@d-m-u
Copy link
Contributor Author

d-m-u commented Jun 26, 2018

@miq-bot add_label performance
@miq-bot add_label bug

@d-m-u
Copy link
Contributor Author

d-m-u commented Jun 27, 2018

Travis fails because we need https://github.com/ManageIQ/manageiq-api/pull/405/files to set the permissions right

@d-m-u d-m-u changed the title [WIP] [GAPRINDASHVILI] [WIP] Pass option to retain dialog values so they're not rerun [GAPRINDASHVILI] Pass option to retain dialog values so they're not rerun Jun 27, 2018
@miq-bot miq-bot removed the wip label Jun 27, 2018
@miq-bot
Copy link
Member

miq-bot commented Jun 27, 2018

Checked commit d-m-u@8aa3d64 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. ⭐

@d-m-u d-m-u closed this Jun 29, 2018
@d-m-u d-m-u reopened this Jun 29, 2018
@gmcculloug
Copy link
Member

@miq-bot assign @simaishi
@eclarizio Please review.

@d-m-u No need to set the gaprindashvili/yes label when the PR is on that branch.

@JPrause
Copy link
Member

JPrause commented Jul 3, 2018

@miq-bot add_label blocker

@miq-bot miq-bot added the blocker label Jul 3, 2018
@JPrause
Copy link
Member

JPrause commented Jul 9, 2018

@eclarizio were you able to review this PR.

@d-m-u
Copy link
Contributor Author

d-m-u commented Jul 9, 2018

@gtanzillo the master equiv of this got merged while I was gone, can you review this one too, please?

@simaishi simaishi merged commit 4097aa8 into ManageIQ:gaprindashvili Jul 11, 2018
@simaishi simaishi added this to the Sprint 90 Ending Jul 16, 2018 milestone Jul 11, 2018
@eclarizio eclarizio mentioned this pull request Jul 18, 2018
Merged
agrare added a commit to agrare/manageiq-api that referenced this pull request Aug 1, 2018
@agrare
Fix typo in service template mixin
cb85138 
There was a typo introduced by
ManageIQ#406 in the service
template mixin, this fixes it to match the PR on master.
@agrare agrare mentioned this pull request Aug 1, 2018
Merged
agrare added a commit to agrare/manageiq-api that referenced this pull request Aug 1, 2018
@agrare
Fix typo in service template mixin
44da1da 
There was a typo introduced by
ManageIQ#406 in the service
template mixin, this fixes it to match the PR on master.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eclarizio eclarizio eclarizio approved these changes

@gtanzillo gtanzillo gtanzillo approved these changes

Assignees

@simaishi simaishi

Labels
blocker bug performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@d-m-u @miq-bot @gmcculloug @JPrause @gtanzillo @eclarizio @simaishi