Add option to reuse dialog values for great justice on master #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eclarizio 👀 please, i'm in middle of testing |
eclarizio
reviewed
Jun 27, 2018
d-m-u
force-pushed
the
bz1584355_master
branch
2 times, most recently
from
95402d1
to
c8581cb
Compare
|
Checked commit d-m-u@6d9a8da with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
This was referenced Jul 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dialogs are being run twice, once on load, once on submit, this lets us reuse the values we picked so they don't rerun on submit.
Fix for https://bugzilla.redhat.com/show_bug.cgi?id=1584355
There's a related main PR.
It's eclarizio's code.
related to
ManageIQ/manageiq#17642