Include task_id in the response when invoking a custom button #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skateman
changed the title
|
@skateman Why did you close it? I need this for https://bugzilla.redhat.com/show_bug.cgi?id=1602023 and ManageIQ/manageiq-ui-classic#4334 . @pkomanek resolved backend at ManageIQ/manageiq-automation_engine#205 and ManageIQ/manageiq#17802 |
|
@ZitaNemeckova sorry |
skateman
changed the title
|
Checked commit skateman@bce3c6f with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@abellotti : can you, please, merge this one? The UI part is already merged. Thx! |
abellotti
approved these changes
Aug 17, 2018
|
LGTM!! @skateman thanks for fixing this. 👍 |
simaishi
pushed a commit
that referenced
this pull request
Sep 13, 2018
Include task_id in the response when invoking a custom button (cherry picked from commit 022cf03) https://bugzilla.redhat.com/show_bug.cgi?id=1618800
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After merging this the API will know the ID of the task that has been created by the custom button action. This can be used further by @ZitaNemeckova for fixing her BZ.
@miq-bot add_reviewer @abellotti
@miq-bot add_label bug, gaprindashvili/yes
https://bugzilla.redhat.com/show_bug.cgi?id=1602023