Include task_id in result of ResourceActionWorkflow#process_request #17788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skateman
force-pushed
the
custom-button-task-id
branch
from
cedf6bb
to
30ebb59
Compare
gmcculloug
reviewed
Aug 1, 2018
There was a problem hiding this comment.
Overall I am good with this change, one small comment. Will merge when @eclarizio has a change to review/approve.
| subject { ResourceActionWorkflow.new({}, admin, resource_action, :target => target) } | ||
| let(:resource_action) { @resource_action } | ||
| let(:task) { double } | ||
|
|
||
| before { allow(task).to receive(:id).and_return(0) } |
There was a problem hiding this comment.
Minor, but I think we should have the test return a non-zero value which is more inline with what we would expect from the db.
skateman
force-pushed
the
custom-button-task-id
branch
from
30ebb59
to
25be312
Compare
|
Some comments on commit skateman@25be312 spec/models/resource_action_workflow_spec.rb
|
1 similar comment
|
Some comments on commit skateman@25be312 spec/models/resource_action_workflow_spec.rb
|
|
Checked commit skateman@25be312 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
gmcculloug
approved these changes
Aug 1, 2018
|
Removed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When invoking a custom button action with a dialog through the API, it is needed to access the created task. This one-liner should include the required task id in the result which can be propagated further in the API.
@miq-bot add_reviewer @pkomanek
@miq-bot add_reviewer @ZitaNemeckova
@miq-bot add_label gaprindashvili/yes, bug
https://bugzilla.redhat.com/show_bug.cgi?id=1602023