Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI: Remove non-existent identifiers in miq_product_features.yml #854

Merged
merged 1 commit into from
Jun 1, 2020

Conversation

lpichler
Copy link
Contributor

@lpichler lpichler commented Jun 1, 2020

This #840 fix test which checks whether identifiers from api.yml exist in also in miq_product_features.yml.

The test found(CI failure) that instance_add_cloud_network , api_provider_show_list don't exist in miq_product_features.yml.

This PR removes them as they were added here

instance_add_cloud_network - it looks like that it is just duplicating create so it can be removed.

api_provider_show_list - this doesn't exist in miq_product_features.yml and we have already features to show list of providers. (ems_infra_show_list, ems_cloud_show_list, ..)

@gubbe505 is it ok to remove api_provider_show_list or do you have any plans to add api_provider_show_list to miq_product_features.yml in https://github.com/ManageIQ/manageiq/blob/master/db/fixtures/miq_product_features.yml for some action ?

thanks

@miq-bot assign @abellotti
@miq-bot add_label bug, jansa/yes

@abellotti
Copy link
Member

Thanks @lpichler for fixing this. 👍

@abellotti abellotti merged commit f9e78b3 into ManageIQ:master Jun 1, 2020
@lpichler lpichler deleted the remove_unwanted_identifiers branch June 1, 2020 18:07
@simaishi simaishi removed the jansa/yes label Jun 2, 2020
@simaishi
Copy link
Contributor

simaishi commented Jun 2, 2020

Removed jansa/yes, #825 isn't backported to jansa branch and this PR isn't needed in jansa.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants