Added parts for the NSX-T provider

[gubbe505]

Added network_services, security_policies and security_policy_rules controllers and added some additional api methods to cloud_networks and providers

[gubbe505]

The build fails probably because of this change:

manageiq-api/app/controllers/api/subcollections/security_groups.rb

Line 5 in e0a50fd

object.respond_to?(:security_groups) ? object.security_groups : {}

In the previous version the security_groups would be converted to an Array and wouldn't be filtered by RBAC. I have looked at other methods and there is no consistent way of returning if the value is nil.

Please advise.

[agrare]

@gtanzillo @bdunne are you able to help with the rbac failure here?

[gtanzillo]

The build fails probably because of this change:

The subquery collection needs to return an array. So this is correct -
object.respond_to?(:security_groups) ? Array(object.security_groups) : []

All results go through Rbac here

manageiq-api/app/controllers/api/base_controller/renderer.rb

Lines 192 to 199 in 1ad20d2

	def filter_results(miq_expression, res, options)
	if miq_expression.present? && options.key?(:limit) && options.key?(:offset)
	subquery_res = Rbac.filtered(res, options.except(:offset, :limit))
	[Rbac.filtered(res, options), subquery_res.count]
	else
	[Rbac.filtered(res, options)]
	end
	end

Looking at https://github.com/ManageIQ/manageiq/blob/048c86151c95786875f00f233704af01b20aec41/lib/rbac/filterer.rb#L60 security groups should get filtered

[gubbe505]

Sorry, my mistake. Had to look up the problem way we changed it. The reason is that mapping to a Array does not support filter as query parameter.

Nevertheless there no consistent way of returning the xxx_query_resource within the api.

[agrare]

Hey @gubbe505 any progress on this?

[miq-bot]

Checked commits gubbe505/manageiq-api@0e4e9d0~...fdbcb0f with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
12 files checked, 0 offenses detected
Everything looks fine. 🏆

[agrare]

Hm I can't replicate the travis error locally, it seems like it can't find one of the tags in the region

[agrare]

Spec failure looks unrelated to this change, ManageIQ/manageiq#20197

[abellotti]

@gubbe505 we seem to be missing the specs here