Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify what is missing if tag assignment failed #20197

Merged

Conversation

yrudman
Copy link
Contributor

@yrudman yrudman commented May 21, 2020

ISSUE:
if tag category or tag name misspelled when executing API call to assign tag than return message did not indicate what went wrong

Example:
curl --user admin:smartvm -i -X POST -d '{"action":"assign","resources":[{"category":"team","name":"it_pnp"}]}' http://localhost:3000/api/vms/54/tags
BEFORE:
{"results":[{"success":false,"message":"Assigning Tag: category:'team' name:'it_pnp'", ...}
AFTER:
{"results":[{"success":false,"message":"Tag category 'team' not found in region 0", ...}

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1792106

@yrudman yrudman force-pushed the provide-descriptive-message-when-tag-missing branch from 191186f to b5a086b Compare May 22, 2020 12:52
@yrudman yrudman force-pushed the provide-descriptive-message-when-tag-missing branch from b5a086b to 3e8b342 Compare May 22, 2020 14:33
@yrudman yrudman requested a review from gtanzillo as a code owner May 22, 2020 14:33
@miq-bot
Copy link
Member

miq-bot commented May 22, 2020

Checked commits yrudman/manageiq@3a56e0e~...3e8b342 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
2 files checked, 0 offenses detected
Everything looks fine. ⭐

@yrudman yrudman changed the title [WIP] Specify what is missing if tag assignment failed Specify what is missing if tag assignment failed May 22, 2020
@yrudman
Copy link
Contributor Author

yrudman commented May 22, 2020

@miq-bot add-label ivanchuk/yes, jansa/yes

@miq-bot miq-bot added ivanchuk/yes and removed wip labels May 22, 2020
@yrudman yrudman closed this May 22, 2020
@yrudman yrudman reopened this May 22, 2020
@chessbyte chessbyte added the bug label May 22, 2020
@kbrock kbrock merged commit 598eede into ManageIQ:master May 26, 2020
@kbrock kbrock self-assigned this May 26, 2020
@yrudman yrudman deleted the provide-descriptive-message-when-tag-missing branch May 26, 2020 21:34
yrudman added a commit to yrudman/manageiq-api that referenced this pull request May 27, 2020
kbrock added a commit to kbrock/manageiq that referenced this pull request May 27, 2020
…ptive-message-when-tag-missing"

This reverts commit 598eede, reversing
changes made to a496b3c.
Fryguy added a commit that referenced this pull request May 27, 2020
Revert "Merge pull request #20197 from yrudman/provide-descriptive-me…
@simaishi
Copy link
Contributor

Removing /yes labels as this was reverted in #20214

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants