-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify what is missing if tag assignment failed #20197
Merged
kbrock
merged 2 commits into
ManageIQ:master
from
yrudman:provide-descriptive-message-when-tag-missing
May 26, 2020
Merged
Specify what is missing if tag assignment failed #20197
kbrock
merged 2 commits into
ManageIQ:master
from
yrudman:provide-descriptive-message-when-tag-missing
May 26, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdunne
reviewed
May 21, 2020
yrudman
force-pushed
the
provide-descriptive-message-when-tag-missing
branch
from
May 22, 2020 12:52
191186f
to
b5a086b
Compare
yrudman
force-pushed
the
provide-descriptive-message-when-tag-missing
branch
from
May 22, 2020 14:33
b5a086b
to
3e8b342
Compare
Checked commits yrudman/manageiq@3a56e0e~...3e8b342 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint |
yrudman
changed the title
[WIP] Specify what is missing if tag assignment failed
Specify what is missing if tag assignment failed
May 22, 2020
@miq-bot add-label ivanchuk/yes, jansa/yes |
yrudman
added a commit
to yrudman/manageiq-api
that referenced
this pull request
May 27, 2020
Fryguy
added a commit
that referenced
this pull request
May 27, 2020
Revert "Merge pull request #20197 from yrudman/provide-descriptive-me…
Removing /yes labels as this was reverted in #20214 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE:
if tag category or tag name misspelled when executing API call to assign tag than return message did not indicate what went wrong
Example:
curl --user admin:smartvm -i -X POST -d '{"action":"assign","resources":[{"category":"team","name":"it_pnp"}]}' http://localhost:3000/api/vms/54/tags
BEFORE:
{"results":[{"success":false,"message":"Assigning Tag: category:'team' name:'it_pnp'", ...}
AFTER:
{"results":[{"success":false,"message":"Tag category 'team' not found in region 0", ...}
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1792106