Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Highline 2.1.0 #201

Merged
merged 7 commits into from
Mar 21, 2023
Merged

Update to Highline 2.1.0 #201

merged 7 commits into from
Mar 21, 2023

Commits on Mar 21, 2023

  1. highline dependency change

    @kbrock
    kbrock committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    5db7c89 View commit details
    Browse the repository at this point in the history

  2. drop expect_readline_question_asked 

    The questions asked and the output are merged together.
This method was only used in one spot so not much lost.
    @kbrock
    kbrock committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    e485fb2 View commit details
    Browse the repository at this point in the history

  3. Handle default value output in highline 

    If we enter a value that is not a default value, but one is derived, then the actual value entered is output.

so if we type in text that infers option 1, then highline now outputs (1)

Not exactly sure why there is a change for a default value being presented,
I'm guessing the value was not checked by the previous test. So the change in expect_heard
shows this at this time
    @kbrock
    kbrock committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    9afb1af View commit details
    Browse the repository at this point in the history

  4. drop highline $terminal 

    This is replaced by HighLine.default_instance
    @kbrock
    kbrock committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    033d152 View commit details
    Browse the repository at this point in the history

  5. move postgres dependency to dependencies

    @kbrock
    kbrock committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    59d8543 View commit details
    Browse the repository at this point in the history

  6. enable (remove pending) for database admin spec

    @kbrock
    kbrock committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    40c910f View commit details
    Browse the repository at this point in the history

  7. drop STDIN.tty? hack 

    this was necessary to get older version of highline up and running in rails
see ManageIQ#178 df5cffb
    @kbrock
    kbrock committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    ff01d19 View commit details
    Browse the repository at this point in the history