Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix post_activation exception when setting up internal database #244

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

agrare
Copy link
Member

@agrare agrare commented Apr 12, 2024

Once both database and messaging have been configured by the CLI, start evmserverd.service. This will work if you pass both database and messaging config in the same invocation or if you configure them separately.

Example command: appliance_console_cli --internal --username='root' --password='smartvm' --region=1 --dbdisk=/dev/vdb --message-server-config --message-keystore-password="smartvm" --server=start

Fixes:

  config.post_activation
        ^^^^^^^^^^^^^^^^
from /opt/manageiq/manageiq-gemset/gems/manageiq-appliance_console-9.0.1/lib/manageiq/appliance_console/cli.rb:297:in `set_db'
from /opt/manageiq/manageiq-gemset/gems/manageiq-appliance_console-9.0.1/lib/manageiq/appliance_console/cli.rb:261:in `run'
from /opt/manageiq/manageiq-gemset/gems/manageiq-appliance_console-9.0.1/lib/manageiq/appliance_console/cli.rb:544:in `parse'
from /opt/manageiq/manageiq-gemset/gems/manageiq-appliance_console-9.0.1/bin/appliance_console_cli:7:in `<top (required)>'
from /opt/manageiq/manageiq-gemset/bin/appliance_console_cli:25:in `load'
from /opt/manageiq/manageiq-gemset/bin/appliance_console_cli:25:in `<main>'

Introduced by #195

Follow-up:

@agrare agrare added the bug label Apr 12, 2024
@agrare

This comment was marked as resolved.

@agrare agrare force-pushed the fix_cli_db_post_activation_error branch 2 times, most recently from 6f0cd35 to 173e4e2 Compare April 12, 2024 17:31
@agrare agrare changed the title Start evmserverd after cli config [WIP] Start evmserverd after cli config Apr 12, 2024
@agrare
Copy link
Member Author

agrare commented Apr 12, 2024

We already have an explicit --server=start option, thinking we just reuse that either by setting options[:server] ||= "start" or just documenting that when you run appliance_console_cli you pass that so the full command would be:

appliance_console_cli --internal --username='root' --password='smartvm' --region=1 --dbdisk=/dev/vdb \
  --message-server-config --message-keystore-password="smartvm" \
  --server=start

Or split up into individual steps:

appliance_console_cli --internal --username='root' --password='smartvm' --region=1 --dbdisk=/dev/vdb
appliance_console_cli --message-server-config --message-keystore-password="smartvm" 
appliance_console_cli --server=start

@Fryguy
Copy link
Member

Fryguy commented Apr 12, 2024

I like the single step version and we can take care of the dependencies internally. So, yeah, seems we can just document that.

@agrare
Copy link
Member Author

agrare commented Apr 12, 2024

Working on adding documentation for the messaging config since it seems that wasn't added, I'll add the --server=start to the examples so people should copy&paste the right thing

@agrare agrare force-pushed the fix_cli_db_post_activation_error branch from 173e4e2 to d66e8f8 Compare April 12, 2024 18:40
@agrare agrare changed the title [WIP] Start evmserverd after cli config Start evmserverd after cli config Apr 16, 2024
@agrare agrare changed the title Start evmserverd after cli config Fix post_activation exception when setting up internal database Apr 16, 2024
@agrare
Copy link
Member Author

agrare commented Apr 16, 2024

Okay I'm going to take this out of WIP since this is functional and the only issues left aren't related to this fix (specifically #245)

Example: appliance_console_cli --internal --username='root' --password='smartvm' --region=1 --dbdisk=/dev/vdb --message-server-config --message-keystore-password="smartvm" --server=start

@Fryguy Fryguy merged commit c221366 into ManageIQ:master Apr 16, 2024
6 checks passed
@agrare agrare deleted the fix_cli_db_post_activation_error branch April 16, 2024 17:37
bdunne added a commit that referenced this pull request May 1, 2024
Fixed
- Bump net-ssh/scp for OpenSSL 3.0 support [#248]
- Start evmserverd after cli config [#244]
- Fix missing i18n with appliance_console_cli [#247]

Changed
- Update paambaati/codeclimate-action action to v6 [#249]
- Add renovate.json [#214]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants