Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump net-ssh/scp for OpenSSL 3.0 support #248

Merged
merged 3 commits into from
May 1, 2024

Conversation

agrare
Copy link
Member

@agrare agrare commented Apr 16, 2024

Fix dh#set_pqg= is incompatible with OpenSSL 3.0

net-ssh/net-ssh#864

Depends on:

Fixes #245

Comment on lines 33 to 34
spec.add_runtime_dependency "net-scp", "~> 4.0"
spec.add_runtime_dependency "net-ssh", "~>7.2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bdunne Please review - I'm curious if there are follow on effect of this large of a bump in both of these.

Copy link
Member

@Fryguy Fryguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but would like a second reviewer... @bdunne ?

@bdunne
Copy link
Member

bdunne commented Apr 30, 2024

LinuxAdmin v3.0.0 is available https://rubygems.org/gems/linux_admin/versions/3.0.0

@miq-bot
Copy link
Member

miq-bot commented Apr 30, 2024

Checked commits agrare/manageiq-appliance_console@54a4059~...d8b2c19 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
0 files checked, 0 offenses detected
Everything looks fine. 🍪

@bdunne bdunne merged commit fed79b9 into ManageIQ:master May 1, 2024
5 of 6 checks passed
@agrare agrare deleted the fix_net_scp_openssl_3_failure branch May 1, 2024 00:20
bdunne added a commit that referenced this pull request May 1, 2024
Fixed
- Bump net-ssh/scp for OpenSSL 3.0 support [#248]
- Start evmserverd after cli config [#244]
- Fix missing i18n with appliance_console_cli [#247]

Changed
- Update paambaati/codeclimate-action action to v6 [#249]
- Add renovate.json [#214]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to fetch key from remote system, fails with dh#set_pqg= is incompatible with OpenSSL 3.0
4 participants