-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump net-ssh/scp for OpenSSL 3.0 support #248
Conversation
manageiq-appliance_console.gemspec
Outdated
spec.add_runtime_dependency "net-scp", "~> 4.0" | ||
spec.add_runtime_dependency "net-ssh", "~>7.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bdunne Please review - I'm curious if there are follow on effect of this large of a bump in both of these.
46141f1
to
bc239c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but would like a second reviewer... @bdunne ?
78fcbe1
to
f2e2f06
Compare
LinuxAdmin v3.0.0 is available https://rubygems.org/gems/linux_admin/versions/3.0.0 |
Checked commits agrare/manageiq-appliance_console@54a4059~...d8b2c19 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
Fix
dh#set_pqg= is incompatible with OpenSSL 3.0
net-ssh/net-ssh#864
Depends on:
Fixes #245