Parse rails runner region output correctly #80
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit carbonin@a756397 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
I'm concerned the real problem is that this new line appeared and that it can cause more problems aside from this one...as such this feels like a bandaid fix, and I'd like to discuss that line. |
|
Yeah, I agree. I'm questioning the utility of adding that line to everything output by a rails runner command. |
carbonin
added a commit
to carbonin/manageiq
that referenced
this pull request
Feb 11, 2019
carbonin
added a commit
to carbonin/manageiq
that referenced
this pull request
Feb 11, 2019
This is breaking production scripts that parse the output of `rails runner`. The codename is nice, but because there is not a reliable way to determine if we're using the server or runner, gating this on the env seems like the best option Alternative to ManageIQ/manageiq-appliance_console#80 Fixes ManageIQ/manageiq-appliance_console#79
|
I'd rather go the other route and fix the output. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #79