Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't print the release codename in production mode #18444

Merged
merged 1 commit into from
Mar 18, 2019

Conversation

carbonin
Copy link
Member

@carbonin carbonin commented Feb 11, 2019

This is breaking production scripts that parse the output
of rails runner. The codename is nice, but because there
is not a reliable way to determine if we're using the server
or runner, gating this on the env seems like the best option

Alternative to ManageIQ/manageiq-appliance_console#80
Fixes ManageIQ/manageiq-appliance_console#79

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1690158

This is breaking production scripts that parse the output
of `rails runner`. The codename is nice, but because there
is not a reliable way to determine if we're using the server
or runner, gating this on the env seems like the best option

Alternative to ManageIQ/manageiq-appliance_console#80
Fixes ManageIQ/manageiq-appliance_console#79
@miq-bot
Copy link
Member

miq-bot commented Feb 12, 2019

Some comments on commit carbonin@f0ed958

config/application.rb

  • ⚠️ - 164 - Detected puts. Remove all debugging statements.

@miq-bot
Copy link
Member

miq-bot commented Feb 12, 2019

Checked commit carbonin@f0ed958 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 1 offense detected

config/application.rb

  • ❗ - Line 164, Col 7 - Rails/Output - Do not write to stdout. Use Rails's logger if you want to log.

@Fryguy Fryguy merged commit a812698 into ManageIQ:master Mar 18, 2019
@Fryguy Fryguy added this to the Sprint 107 Ending Mar 18, 2019 milestone Mar 18, 2019
@carbonin
Copy link
Member Author

https://bugzilla.redhat.com/show_bug.cgi?id=1690158

@tjyang
Copy link

tjyang commented Mar 19, 2019

Thanks @carbonin and @Fryguy , I confirm the fix works. Hope this fix will be merged into hammer-4.

simaishi pushed a commit that referenced this pull request Mar 29, 2019
Don't print the release codename in production mode

(cherry picked from commit a812698)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1693748
@simaishi
Copy link
Contributor

Hammer backport details:

$ git log -1
commit 9761006687e1b0610429739e2cb2befae53c5c1a
Author: Jason Frey <fryguy9@gmail.com>
Date:   Mon Mar 18 17:40:14 2019 -0400

    Merge pull request #18444 from carbonin/dont_print_codename_in_prod
    
    Don't print the release codename in production mode
    
    (cherry picked from commit a8126980eb352916b810c7a33315a9e42080dec8)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1693748

@carbonin carbonin deleted the dont_print_codename_in_prod branch August 16, 2019 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants