Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add expose check_connection to generic service #465

Merged
merged 1 commit into from
Nov 12, 2020
Merged

add expose check_connection to generic service #465

merged 1 commit into from
Nov 12, 2020

Conversation

d-m-u
Copy link
Contributor

@d-m-u d-m-u commented Nov 11, 2020

We need to expose check_connection, see the rest of the related changes on ManageIQ/manageiq#20773.

@miq-bot add_label ivanchuk/yes

part of https://bugzilla.redhat.com/show_bug.cgi?id=1835226 fix

@miq-bot
Copy link
Member

miq-bot commented Nov 11, 2020

Checked commit d-m-u@19f2e6d with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. 🍪

tinaafitz
tinaafitz approved these changes Nov 11, 2020
View reviewed changes
Copy link
Member

@tinaafitz tinaafitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @d-m-u!

@coveralls
Copy link

coveralls commented Nov 11, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 4670

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 85.763%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/miq_automation_engine/service_models/miq_ae_service_service_generic.rb 0 1 0.0%
Totals Coverage Status
Change from base Build 4612: 0.02%
Covered Lines: 5018
Relevant Lines: 5851
💛 - Coveralls

@d-m-u d-m-u closed this Nov 12, 2020
@d-m-u d-m-u reopened this Nov 12, 2020
@tinaafitz tinaafitz merged commit e0aa23f into ManageIQ:master Nov 12, 2020
@d-m-u d-m-u deleted the adding_check_connection_expose branch November 12, 2020 15:07
simaishi pushed a commit that referenced this pull request Nov 12, 2020
@tinaafitz @simaishi
Merge pull request #465 from d-m-u/adding_check_connection_expose
9211d19 
add expose check_connection to generic service

(cherry picked from commit e0aa23f)

https://bugzilla.redhat.com/show_bug.cgi?id=1835226
@simaishi
Copy link
Contributor

Ivanchuk backport details:

$ git log -1
commit 9211d19af417a131df8de43dab18141d5d2af70f
Author: tina <tfitzger@redhat.com>
Date:   Thu Nov 12 10:06:13 2020 -0500

    Merge pull request #465 from d-m-u/adding_check_connection_expose

    add expose check_connection to generic service

    (cherry picked from commit e0aa23f340d4fb2e689205697a10a4a251f13311)

    https://bugzilla.redhat.com/show_bug.cgi?id=1835226

simaishi pushed a commit that referenced this pull request Nov 12, 2020
@tinaafitz @simaishi
Merge pull request #465 from d-m-u/adding_check_connection_expose
adfb7d5 
add expose check_connection to generic service

(cherry picked from commit e0aa23f)
@simaishi
Copy link
Contributor

Jansa backport details:

$ git log -1
commit adfb7d591b341b0468f2654b538f0d8cdd24b50b
Author: tina <tfitzger@redhat.com>
Date:   Thu Nov 12 10:06:13 2020 -0500

    Merge pull request #465 from d-m-u/adding_check_connection_expose

    add expose check_connection to generic service

    (cherry picked from commit e0aa23f340d4fb2e689205697a10a4a251f13311)

simaishi pushed a commit that referenced this pull request Nov 12, 2020
@tinaafitz @simaishi
Merge pull request #465 from d-m-u/adding_check_connection_expose
c798cda 
add expose check_connection to generic service

(cherry picked from commit e0aa23f)
@simaishi
Copy link
Contributor

Kasparov backport details:

$ git log -1
commit c798cda01ffc0cb03f8634242006ed02e810a6af
Author: tina <tfitzger@redhat.com>
Date:   Thu Nov 12 10:06:13 2020 -0500

    Merge pull request #465 from d-m-u/adding_check_connection_expose

    add expose check_connection to generic service

    (cherry picked from commit e0aa23f340d4fb2e689205697a10a4a251f13311)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tinaafitz tinaafitz tinaafitz approved these changes

@lfu lfu Awaiting requested review from lfu

Assignees
No one assigned
Labels
ivanchuk/backported jansa/backported kasparov/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@d-m-u @miq-bot @coveralls @simaishi @tinaafitz