don't call postprocess without job in playbook on_error #20773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tinaafitz please review |
d-m-u
force-pushed
the
no_postprocess_without_job
branch
from
239d9ad
to
574fcd9
Compare
|
Checked commit d-m-u@574fcd9 with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint |
tinaafitz
approved these changes
Nov 3, 2020
|
@djberg96 Please review. |
|
@d-m-u Can this be |
|
@miq-bot add_label ivanchuk/yes |
simaishi
pushed a commit
that referenced
this pull request
Nov 9, 2020
don't call postprocess without job in playbook on_error (cherry picked from commit 19f3728) https://bugzilla.redhat.com/show_bug.cgi?id=1835226
|
Ivanchuk backport details: |
simaishi
pushed a commit
that referenced
this pull request
Nov 9, 2020
don't call postprocess without job in playbook on_error (cherry picked from commit 19f3728)
|
Jansa backport details: |
simaishi
pushed a commit
that referenced
this pull request
Nov 9, 2020
don't call postprocess without job in playbook on_error (cherry picked from commit 19f3728)
|
Kasparov backport details: |
simaishi
added
ivanchuk/backported
jansa/backported
kasparov/backported
and removed
ivanchuk/yes
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
playbook postprocessing shouldn't happen if the job is nil in
on_errorsince having a nil job is a potential outcome of the valid scenarios we're trying to handle with the retry of ansible playbook connection stuff (see the related pr), we also need to handle this logic branch
related to the work done on #20738