Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unused code from used_spec method. #239

Merged
merged 1 commit into from
Jan 19, 2018

Conversation

billfitzgerald0120
Copy link
Contributor

@billfitzgerald0120 billfitzgerald0120 commented Jan 10, 2018

Removed counts_hash

Before screenshot:
image

After screenshot:
image

https://trello.com/c/5Fh5jeMz/108-improve-coverage-for-all-specs-and-methods

@miq-bot miq-bot added the wip label Jan 10, 2018
@miq-bot
Copy link
Member

miq-bot commented Jan 10, 2018

Checked commit billfitzgerald0120@fe0b3dc with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. ⭐

@billfitzgerald0120 billfitzgerald0120 changed the title [WIP] Removed unused code from used_spec method. Removed unused code from used_spec method. Jan 10, 2018
@billfitzgerald0120
Copy link
Contributor Author

@miq-bot add_label cleanup

@billfitzgerald0120
Copy link
Contributor Author

@tinaafitz Please Review

Copy link
Member

@tinaafitz tinaafitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@billfitzgerald0120 Looks good.

@gmcculloug
Copy link
Member

@billfitzgerald0120 The failing tests are unrelated to this PR. See ManageIQ/manageiq#16804.

@mkanoor mkanoor merged commit 68cc522 into ManageIQ:master Jan 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants