[WIP] Fixes logic for allowed_cloud_networks #16804
Conversation
|
@miq-bot assign @gmcculloug |
|
@miq-bot add_label provisioning |
|
@miq-bot add_label gaprindashvili/yes |
|
Checked commit d-m-u@ffadf3f with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
There was a problem hiding this comment.
Tested in UI, fixes an issue I've ran into: 👍
F, [2018-01-11T15:24:48.047465 #27722] FATAL -- : Error caught: [NoMethodError] undefined method `cloud_network_id' for nil:NilClass
/home/rblanco/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/bundler/gems/manageiq-gems-pending-f793b3c6929e/lib/gems/pending/util/extensions/miq-object.rb:9:in `deep_send'
/home/rblanco/devel/manageiq/app/models/manageiq/providers/cloud_manager/provision_workflow.rb:121:in `get_targets_for_source'
/home/rblanco/devel/manageiq/app/models/manageiq/providers/cloud_manager/provision_workflow.rb:31:in `allowed_cloud_networks'
/home/rblanco/devel/manageiq/app/models/miq_request_workflow.rb:288:in `get_field'
/home/rblanco/devel/manageiq/app/models/miq_request_workflow.rb:275:in `block in get_all_fields'
/home/rblanco/devel/manageiq/app/models/miq_request_workflow.rb:275:in `each_key'
/home/rblanco/devel/manageiq/app/models/miq_request_workflow.rb:275:in `get_all_fields'
/home/rblanco/devel/manageiq/app/models/miq_request_workflow.rb:103:in `block in init_from_dialog'
/home/rblanco/devel/manageiq/app/models/miq_request_workflow.rb:102:in `each'
/home/rblanco/devel/manageiq/app/models/miq_request_workflow.rb:102:in `init_from_dialog'
/home/rblanco/devel/manageiq-ui-classic/app/controllers/application_controller/miq_request_methods.rb:835:in `prov_set_form_vars'
/home/rblanco/devel/manageiq-ui-classic/app/controllers/catalog_controller.rb:144:in `atomic_form_field_changed'
d-m-u
changed the title
| source = load_ar_obj(get_source_vm) | ||
| targets = get_targets_for_source(source, :cloud_filter, CloudNetwork, 'cloud_network_id') | ||
| allowed_ci(:cloud_network, [:availability_zone], targets.map(&:id)) | ||
|
|
||
| if src_obj.all_cloud_networks.nil? |
There was a problem hiding this comment.
It wasn't always returning an array.
There was a problem hiding this comment.
Can you provide a reference to where it would not? Is this just in a testing scenario?
| if src_obj.all_cloud_networks.nil? | ||
| return allowed_ci(:cloud_network, [:availability_zone], targets.map(&:id)) | ||
| else | ||
| src_obj.all_cloud_networks.each_with_object({}) do |cn, hash| |
There was a problem hiding this comment.
This fixes the tests but is it really addressing the original issue of rbac filtering on this element?
|
drew and I consensus'd and have a suggestion for the following course of action:
and if still necessary at this point: |
|
We think that this has been replaced with |
|
Closing because the two PRs listed in comment above cover both UI issue and broken test in content repo. |
This fixes an issue discovered late yesterday wherein the filtering done on cloud network lists was returning incorrect values as of the merge of #16688
WIP because @syncrou and I are conversating about what to do with this